Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory] Adding feedback button #195716

Merged
merged 10 commits into from
Oct 14, 2024
Merged

[Inventory] Adding feedback button #195716

merged 10 commits into from
Oct 14, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Oct 10, 2024 •
edited by kibanamachine
Loading

Screenshot 2024-10-10 at 10 04 51 Screenshot 2024-10-10 at 10 05 24

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Oct 10, 2024
@cauemarcondes cauemarcondes requested review from a team as code owners October 10, 2024 09:08
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 10, 2024
@cauemarcondes cauemarcondes enabled auto-merge (squash) October 10, 2024 10:30
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 14, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 216.3KB 216.5KB +214.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
inventory 10.2KB 10.6KB +412.0B

History

@cauemarcondes cauemarcondes merged commit 4428c80 into elastic:main Oct 14, 2024
28 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https:/elastic/kibana/actions/runs/11325331238

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2024
@cauemarcondes
[Inventory] Adding feedback button (elastic#195716)
b48635c 
<img width="1616" alt="Screenshot 2024-10-10 at 10 04 51"
src="https:/user-attachments/assets/b543a156-ea5e-46ba-9460-e86d7ca6e5a1">
<img width="1600" alt="Screenshot 2024-10-10 at 10 05 24"
src="https:/user-attachments/assets/a2d7973f-53b3-4bf9-a917-8ce496d3c943">

---------

Co-authored-by: jennypavlova <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 4428c80)
@kibanamachine kibanamachine mentioned this pull request Oct 14, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 14, 2024
@kibanamachine @cauemarcondes
[8.x] [Inventory] Adding feedback button (#195716) (#196080)
1c98c7a 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory] Adding feedback button
(#195716)](#195716)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https:/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T10:05:16Z","message":"[Inventory]
Adding feedback button (#195716)\n\n<img width=\"1616\" alt=\"Screenshot
2024-10-10 at 10 04
51\"\r\nsrc=\"https:/user-attachments/assets/b543a156-ea5e-46ba-9460-e86d7ca6e5a1\">\r\n<img
width=\"1600\" alt=\"Screenshot 2024-10-10 at 10 05
24\"\r\nsrc=\"https:/user-attachments/assets/a2d7973f-53b3-4bf9-a917-8ce496d3c943\">\r\n\r\n---------\r\n\r\nCo-authored-by:
jennypavlova <[email protected]>\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"4428c80189ff2899e86c9d1705d50932814cb29f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory]
Adding feedback
button","number":195716,"url":"https:/elastic/kibana/pull/195716","mergeCommit":{"message":"[Inventory]
Adding feedback button (#195716)\n\n<img width=\"1616\" alt=\"Screenshot
2024-10-10 at 10 04
51\"\r\nsrc=\"https:/user-attachments/assets/b543a156-ea5e-46ba-9460-e86d7ca6e5a1\">\r\n<img
width=\"1600\" alt=\"Screenshot 2024-10-10 at 10 05
24\"\r\nsrc=\"https:/user-attachments/assets/a2d7973f-53b3-4bf9-a917-8ce496d3c943\">\r\n\r\n---------\r\n\r\nCo-authored-by:
jennypavlova <[email protected]>\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"4428c80189ff2899e86c9d1705d50932814cb29f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https:/elastic/kibana/pull/195716","number":195716,"mergeCommit":{"message":"[Inventory]
Adding feedback button (#195716)\n\n<img width=\"1616\" alt=\"Screenshot
2024-10-10 at 10 04
51\"\r\nsrc=\"https:/user-attachments/assets/b543a156-ea5e-46ba-9460-e86d7ca6e5a1\">\r\n<img
width=\"1600\" alt=\"Screenshot 2024-10-10 at 10 05
24\"\r\nsrc=\"https:/user-attachments/assets/a2d7973f-53b3-4bf9-a917-8ce496d3c943\">\r\n\r\n---------\r\n\r\nCo-authored-by:
jennypavlova <[email protected]>\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"4428c80189ff2899e86c9d1705d50932814cb29f"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

@jloleysens jloleysens jloleysens approved these changes

@jennypavlova jennypavlova Awaiting requested review from jennypavlova

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cauemarcondes @elasticmachine @kibanamachine @crespocarlos @jloleysens @jennypavlova