Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add timeouts for retries for docker image build #195915

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Oct 11, 2024

Summary

The generated version of the docker image builder script didn't have timeouts between retries, so a temporary outage on docker.elastic.co would cause a docker pull error, failing the build (see: https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)

This PR adds a fix 15s per retry to the docker build runner.

@delanni delanni added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development labels Oct 11, 2024
@delanni delanni changed the title add sleep between retries for kibana docker image build [CI] Add timeouts for retries for docker image build Oct 11, 2024
@delanni delanni marked this pull request as ready for review October 11, 2024 14:28
@delanni delanni requested a review from a team as a code owner October 11, 2024 14:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@delanni
Copy link
Contributor Author

delanni commented Oct 11, 2024

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

@delanni delanni merged commit 1bd8144 into main Oct 14, 2024
29 of 30 checks passed
@delanni delanni deleted the sleep-between-retries-in-docker-build branch October 14, 2024 10:57
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https:/elastic/kibana/actions/runs/11326127162

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2024
## Summary
The generated version of the docker image builder script didn't have
timeouts between retries, so a temporary outage on `docker.elastic.co`
would cause a docker pull error, failing the build (see:
https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)

This PR adds a fix 15s per retry to the docker build runner.

(cherry picked from commit 1bd8144)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2024
## Summary
The generated version of the docker image builder script didn't have
timeouts between retries, so a temporary outage on `docker.elastic.co`
would cause a docker pull error, failing the build (see:
https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)

This PR adds a fix 15s per retry to the docker build runner.

(cherry picked from commit 1bd8144)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 14, 2024
…196108)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[CI] Add timeouts for retries for docker image build
(#195915)](#195915)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https:/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T10:57:07Z","message":"[CI]
Add timeouts for retries for docker image build (#195915)\n\n##
Summary\r\nThe generated version of the docker image builder script
didn't have\r\ntimeouts between retries, so a temporary outage on
`docker.elastic.co`\r\nwould cause a docker pull error, failing the
build
(see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis
PR adds a fix 15s per retry to the docker build
runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major","ci:build-cloud-image"],"title":"[CI]
Add timeouts for retries for docker image
build","number":195915,"url":"https:/elastic/kibana/pull/195915","mergeCommit":{"message":"[CI]
Add timeouts for retries for docker image build (#195915)\n\n##
Summary\r\nThe generated version of the docker image builder script
didn't have\r\ntimeouts between retries, so a temporary outage on
`docker.elastic.co`\r\nwould cause a docker pull error, failing the
build
(see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis
PR adds a fix 15s per retry to the docker build
runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https:/elastic/kibana/pull/195915","number":195915,"mergeCommit":{"message":"[CI]
Add timeouts for retries for docker image build (#195915)\n\n##
Summary\r\nThe generated version of the docker image builder script
didn't have\r\ntimeouts between retries, so a temporary outage on
`docker.elastic.co`\r\nwould cause a docker pull error, failing the
build
(see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis
PR adds a fix 15s per retry to the docker build
runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c"}}]}]
BACKPORT-->

Co-authored-by: Alex Szabo <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 14, 2024
…#196107)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[CI] Add timeouts for retries for docker image build
(#195915)](#195915)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https:/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T10:57:07Z","message":"[CI]
Add timeouts for retries for docker image build (#195915)\n\n##
Summary\r\nThe generated version of the docker image builder script
didn't have\r\ntimeouts between retries, so a temporary outage on
`docker.elastic.co`\r\nwould cause a docker pull error, failing the
build
(see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis
PR adds a fix 15s per retry to the docker build
runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major","ci:build-cloud-image"],"title":"[CI]
Add timeouts for retries for docker image
build","number":195915,"url":"https:/elastic/kibana/pull/195915","mergeCommit":{"message":"[CI]
Add timeouts for retries for docker image build (#195915)\n\n##
Summary\r\nThe generated version of the docker image builder script
didn't have\r\ntimeouts between retries, so a temporary outage on
`docker.elastic.co`\r\nwould cause a docker pull error, failing the
build
(see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis
PR adds a fix 15s per retry to the docker build
runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https:/elastic/kibana/pull/195915","number":195915,"mergeCommit":{"message":"[CI]
Add timeouts for retries for docker image build (#195915)\n\n##
Summary\r\nThe generated version of the docker image builder script
didn't have\r\ntimeouts between retries, so a temporary outage on
`docker.elastic.co`\r\nwould cause a docker pull error, failing the
build
(see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis
PR adds a fix 15s per retry to the docker build
runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c"}}]}]
BACKPORT-->

Co-authored-by: Alex Szabo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development ci:build-cloud-image release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.15.3 v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants