Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Onboarding] Remove System Logs onboarding flow #196132

Merged
merged 6 commits into from
Oct 17, 2024
Merged

[Onboarding] Remove System Logs onboarding flow #196132

merged 6 commits into from
Oct 17, 2024

Conversation

mykolaharmash
Copy link
Contributor

Closes #192815

Removes the legacy System Logs onboarding flow as it now has been replaced by the Auto-Detect flow.

@mykolaharmash mykolaharmash marked this pull request as ready for review October 14, 2024 12:58
@mykolaharmash mykolaharmash requested review from a team as code owners October 14, 2024 12:58
@mykolaharmash mykolaharmash added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 14, 2024
@mykolaharmash mykolaharmash force-pushed the 192815-onboarding-remove-the-system-logs-onboarding-flow branch from eab0162 to baf6f0b Compare October 14, 2024 13:53
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 14, 2024
@mykolaharmash mykolaharmash force-pushed the 192815-onboarding-remove-the-system-logs-onboarding-flow branch from 52cf217 to b2949e8 Compare October 15, 2024 12:08
@mykolaharmash mykolaharmash changed the title 192815 onboarding remove the system logs onboarding flow [Onboarding] Remove System Logs onboarding flow Oct 15, 2024
maryam-saeidi
maryam-saeidi approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, obs-ux-management change LGTM!

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 17, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: f3292c7
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-196132-f3292c7178d6

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #88 / InfraOps App Metrics UI Node Details #Asset Type: host Processes Tab should render processes tab and with Total Value summary

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 261 255 -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 292.4KB 282.8KB -9.6KB
Unknown metric groups

ESLint disabled line counts

id before after diff
observabilityOnboarding 13 11 -2

Total ESLint disabled count

id before after diff
observabilityOnboarding 18 16 -2

History

thomheymann
thomheymann approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mykolaharmash mykolaharmash merged commit db574f4 into elastic:main Oct 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomheymann thomheymann thomheymann approved these changes

@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Onboarding] Remove the system logs onboarding flow
5 participants
@mykolaharmash @elasticmachine @thomheymann @maryam-saeidi @kibanamachine