Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory] List k8s entities in the grid #197292

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[Inventory] List k8s entities in the grid #197292

wants to merge 18 commits into from
+127 −273

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Oct 22, 2024 •
edited
Loading

closes #196155
Blocked by #196916 (K8s entities alias patterns don't exist yet.)

Screen.Recording.2024-10-22.at.16.mp4

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.17.0 labels Oct 22, 2024
@cauemarcondes cauemarcondes marked this pull request as ready for review October 22, 2024 15:56
@cauemarcondes cauemarcondes requested a review from a team as a code owner October 22, 2024 15:56
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

kpatticha
kpatticha reviewed Oct 23, 2024
View reviewed changes
x-pack/plugins/observability_solution/inventory/server/routes/entities/get_latest_entities.ts
const sort = `SORT ${entitiesSortField} ${sortDirection}`;
const limit = `LIMIT ${MAX_NUMBER_OF_ENTITIES}`;

const query = [from, ...where, sort, limit].join(' | ');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, much easier to read.

kpatticha
kpatticha reviewed Oct 23, 2024
View reviewed changes
x-pack/plugins/observability_solution/inventory/server/routes/entities/get_latest_entities.ts
const where: string[] = [getBuiltinEntityDefinitionIdESQLWhereClause()];

if (entityTypes) {
where.push(getEntityTypesWhereClause(entityTypes));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the entityTypes could be any string that the user passes, maybe it's time to use the params. Up to you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but it was throwing an error. I was having another look at the types now and apparently I missed something... will try it again. Thanks.

kpatticha
kpatticha approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it only with the node scripts/synthtrace k8s_entities and it looks good. it would be nice to have a way to test all the entities

@cauemarcondes
Copy link
Contributor Author

I tested it only with the node scripts/synthtrace k8s_entities and it looks good. it would be nice to have a way to test all the entities

I'll create a scenario with all entities we have support up until now.

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 227 226 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 218.6KB 218.1KB -550.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpatticha kpatticha kpatticha approved these changes

@crespocarlos crespocarlos Awaiting requested review from crespocarlos

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Inventory] List k8s entities in the grid
3 participants
@cauemarcondes @elasticmachine @kpatticha