translate InfraOps visualization component (Part 1 - folder pages) #25194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
…1 - folder components)
💔 Build Failed |
|
retest |
💔 Build Failed |
💚 Build Succeeded |
maryia-lapata
suggested changes
Nov 9, 2018
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
| @@ -25,6 +26,8 @@ | |||
| "src/ui/ui_render/bootstrap/app_bootstrap.js", | |||
| "src/ui/ui_render/ui_render_mixin.js", | |||
| "x-pack/plugins/monitoring/public/components/cluster/overview/alerts_panel.js", | |||
| "x-pack/plugins/monitoring/public/directives/alerts/index.js" | |||
| "x-pack/plugins/monitoring/public/directives/alerts/index.js", | |||
| "x-pack/plugins/infra/public/utils/loading_state/loading_result.ts", | |||
There was a problem hiding this comment.
These files were excluded because i18n validation tool can not parse them due to an issue in babel parser which is used by the tool.
💚 Build Succeeded |
weltenwort
requested changes
Nov 13, 2018
There was a problem hiding this comment.
Thanks for slogging through this long list of labels. ❤️
Since you couldn't derive the semantics of the layouts from just reading this code, I tried to add some samples of ids below, which I hope would be more stable in future iterations of these pages. Let me know if they make sense and provide enough detail to extrapolate to the other labels I didn't comment on.
x-pack/plugins/infra/public/pages/link_to/redirect_to_node_logs.tsx
Outdated
Show resolved
Hide resolved
4 tasks
… intl.formatMessage() and directly wrap some classes by injectI18n()
💔 Build Failed |
|
retest |
💔 Build Failed |
💚 Build Succeeded |
weltenwort
requested changes
Nov 19, 2018
weltenwort
approved these changes
Nov 20, 2018
💚 Build Succeeded |
💚 Build Succeeded |
tibmt
added a commit
to tibmt/kibana
that referenced
this pull request
Nov 20, 2018
…lastic#25194) * translate InfraOps vizualization component (Part 1 - folder pages) * update translation of Beats Management vizualization component (Part 1 - folder components) * Update toolbar.tsx * update translation of Beats Management vizualization component (Part 1 - folder components) * update translation of Infra Ops vizualization component (Part 1) * update translation of Infra Ops vizualization component (Part 1) * update Infra Ops Part 1 - change some ids, change i18n.translate() to intl.formatMessage() and directly wrap some classes by injectI18n() * update Infra-I - add static to displayName, update some ids
💚 Build Succeeded |
tibmt
added a commit
that referenced
this pull request
Nov 21, 2018
…25194) (#25936) * translate InfraOps vizualization component (Part 1 - folder pages) * update translation of Beats Management vizualization component (Part 1 - folder components) * Update toolbar.tsx * update translation of Beats Management vizualization component (Part 1 - folder components) * update translation of Infra Ops vizualization component (Part 1) * update translation of Infra Ops vizualization component (Part 1) * update Infra Ops Part 1 - change some ids, change i18n.translate() to intl.formatMessage() and directly wrap some classes by injectI18n() * update Infra-I - add static to displayName, update some ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate InfraOps visualization component (Part 1 - folder pages)
Issue #25523
Guidline
Readme
You can also set up a pseudo-locale to see what labels are translated. Pseudo-locale adds diacritical mark to each
[A-Za-z]character and duplicates every third character to increase messages length by approx. 33%. It's also used to check whether ui breaks with increased message length or not.How to use:
Set
i18n.localetoen-xain./config/kibana.ymlRestart
yarn start.