Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve x-axis ordering in split series vis. #27723

Closed
wants to merge 8 commits into from

Commits on Jan 15, 2019

  1. Fix typo in function name

    lukeelmers committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    3b53c82 View commit details
    Browse the repository at this point in the history
  2. Preserve x-axis ordering in split series vis.

    This resolves an issue where the original sort order sent back by ES was
    lost for point series / vislib visualizations with split series. This
    was due to the way the point series agg response handler generated
    series data, only filling in series values as it encountered them
    bucket-by-bucket, rather than first looking at all x-values and ordering
    them consistently within each series.
    
    With this change, when a series is first created in the `agg_response`, it
    will first look at all results, preserving the x-value sort order. Then
    when creating new series, it will instantiate a zero-filled array with
    the correctly ordered x axis values, filling it in with the real values
    as it encounters them.
    
    This duplicates some of the work done in the vislib `zero_injection`
    component, which can likely be cleaned up further, or possibly removed
    entirely.
    lukeelmers committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    c5d0eb2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    edac25e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3f6e0c3 View commit details
    Browse the repository at this point in the history
  5. Add TODO

    lukeelmers committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    caebdd0 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Add unit test & clean up.

    lukeelmers committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    9e613b3 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. Configuration menu
    Copy the full SHA
    368a0e4 View commit details
    Browse the repository at this point in the history
  2. Update fake x aspects

    lukeelmers committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    661757b View commit details
    Browse the repository at this point in the history