Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Remove deprecated angularjs directives. #28564

Merged
merged 3 commits into from
Jan 11, 2019
Merged

[ML] Remove deprecated angularjs directives. #28564

merged 3 commits into from
Jan 11, 2019

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jan 11, 2019 •
edited
Loading

Summary

Follow up to #28234. Some more angularjs directive code can be removed now after migrating to React. Part of #18374.

@walterra walterra added non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 :ml refactoring Feature:ml-results legacy - do not use v6.7.0 labels Jan 11, 2019
@walterra walterra self-assigned this Jan 11, 2019
@walterra walterra requested a review from a team as a code owner January 11, 2019 10:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

peteharverson
peteharverson approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic
jgowdyelastic approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@walterra
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra merged commit 98ec9e1 into elastic:master Jan 11, 2019
@walterra walterra deleted the ml-explorer-deprecations branch January 11, 2019 12:27
alvarezmelissa87
alvarezmelissa87 reviewed Jan 11, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra mentioned this pull request Jan 11, 2019
Merged
walterra added a commit to walterra/kibana that referenced this pull request Jan 11, 2019
@walterra
[ML] Remove deprecated angularjs directives. (elastic#28564)
2b78a15 
* [ML] Remove deprecated show-charts directive.
* [ML] Remove deprecated ml-controls-select directive.
* [ML] Remove deprecated SCSS import.
walterra added a commit that referenced this pull request Jan 11, 2019
@walterra
[ML] Remove deprecated angularjs directives. (#28564) (#28578)
44f416d 
* [ML] Remove deprecated show-charts directive.
* [ML] Remove deprecated ml-controls-select directive.
* [ML] Remove deprecated SCSS import.
@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 left review comments

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@walterra walterra

Labels
Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml non-issue Indicates to automation that a pull request should not appear in the release notes refactoring v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @alvarezmelissa87 @peteharverson @jgowdyelastic @sophiec20