[6.x] Preserve x-axis ordering in split series vis. #28733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue where the original sort order sent back by ES was lost for point series / vislib visualizations with split series. This was due to the way the point series agg response handler generated series data, only filling in series values as it encountered them bucket-by-bucket, rather than first looking at all x-values and ordering them consistently within each series. With this change, when a series is first created in the `agg_response`, it will first look at all results, preserving the x-value sort order. Then when creating new series, it will instantiate a zero-filled array with the correctly ordered x axis values, filling it in with the real values as it encounters them. This duplicates some of the work done in the vislib `zero_injection` component, which can likely be cleaned up further, or possibly removed entirely.
This comment has been minimized.
This comment has been minimized.
lukeelmers
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Build Failed |
💔 Build Failed |
|
Closing in favor of #31533 |
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed in favor of #31533
Backport of #27723, which requires a different implementation for
6.xthan it does formaster.