Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate core API docs from TSDoc comments #32148
Generate core API docs from TSDoc comments #32148
Changes from 19 commits
a3c0b59
ee431ce
70e25d7
8bcc4a2
4cc5f34
9926ab4
8a0db42
57f56a3
a286fca
5d536cd
02cc3ee
3e26615
c343f80
720c729
c7f45a9
d45d289
20384da
1797e1e
dcefd8d
a738bc9
e397c9a
f19380a
e73167d
a487c16
77f0cb0
2352343
969e2e3
cb5ff8f
0ad507e
9490881
5f6c583
463d13c
d3665d8
0e15328
3df7d6b
304e533
51b8bc1
e6660ab
c325a56
21f5abf
c69c601
74bc082
979c57a
0615c25
f64751c
cfcfb4e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorta conflicted on the choice to put this in the "common" directory at the root of the repository. I'm not sure why this directory exists in the first place, but could you help me understand why this placement makes sense?
I'm conflicted because I can't really think of a better place to put it, though I feel like we might be able to come up with something a little more self explanatory than "common".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't really like "common" either, it doesn't mean anything to me or describe to me what's inside of this folder. The
common
directory is the convention used by api-generator and Microsoft uses that convention in most of their projects. The graphql introspection files seem to follow the same convention, so I thought I'll stick to that in the absence of any better ideas.We don't want to put this in
/src
cause it is a generated file, not a source file. We don't want it in/build
cause it needs to get commited so that we can compare changes to the api signature. We could potentially put this is/dev
or create a more descriptive top-level directory likeapi_signature
which could also be the home for the GraphQL introspection files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it helps, we have one precedent in the repo today for committing a generated file, and that is under a
dist
directory at the root of that package: https:/elastic/kibana/tree/master/packages/kbn-pm/distThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api-extractor now creates a .md file so it's safe to put the API review file with the source code, so I've moved the review file into the /public /server directories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these docs mention an index file that doesn't exist, can we generate one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could create one, but not sure what we would put inside it? Perhaps we can create a symlink that points to
./kibana
, then at least you don't click through to a page that doesn't exist.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually kinda hoping it would have a table of contents listing the existing docs or something like that. I think it'd be nice to see from a high level what is/isn't documented.