-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer package X-Pack as a node module #32722
Conversation
Pinging @elastic/kibana-operations |
x-pack/tasks/build.js
Outdated
const pkg = JSON.parse(readFileSync(resolve(buildRoot, 'package.json'))); | ||
|
||
pkg.dependencies = Object.keys(pkg.dependencies) | ||
.filter((d) => !projects.has(d)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking we could additionally remove any dependencies with the same version qualifier as the dependency in Kibana. Thoughts? I still need to see how much additional overhead we are looking at currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add any context on what's happening? wouldn't yarn workspace dedupe these to the top level automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, this is outside the scope of kbn-pm et all as a side effect
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@tylersmalley so just for our own clarification's sake in APM ... the imports that used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM fror APM ...
Sidenote: would love to consider some way of aliasing imports from Kibana's root to avoid relative imports that go 3+ levels, much easier to read:
from 'kibana/x-pack/plugins/apm/typings/Transaction'
than
from '../../../../../../../../../../typings/Transaction'
2037cc5
to
70e5be4
Compare
This comment has been minimized.
This comment has been minimized.
70e5be4
to
579f493
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@jbudz mind reviewing this? |
@spalger might have some opinions as well. |
It looks like x-pack is still in node_modules, (and in root). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3f61dc0
to
087c998
Compare
Signed-off-by: Tyler Smalley <[email protected]>
087c998
to
a039578
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we're missing -oss on the extracted folder?
➜ Downloads ls
kibana-oss-8.0.0-SNAPSHOT-linux-x86_64.tar.gz
➜ Downloads tar -xf kibana-oss-8.0.0-SNAPSHOT-linux-x86_64.tar.gz >/dev/null
➜ Downloads ls
kibana-8.0.0-SNAPSHOT-linux-x86_64 kibana-oss-8.0.0-SNAPSHOT-linux-x86_64.tar.gz
edit: nevermind, that's consistent with 6.7
This comment has been minimized.
This comment has been minimized.
Regarding the |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Tyler Smalley <[email protected]>
2392b91
to
af23c65
Compare
retest |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Tyler Smalley <[email protected]>
💚 Build Succeeded |
Signed-off-by: Tyler Smalley <[email protected]>
Signed-off-by: Tyler Smalley <[email protected]>
Signed-off-by: Tyler Smalley <[email protected]>
Fixes #31471