Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New platform move deps #33787

Closed
wants to merge 25 commits into from
Closed

New platform move deps #33787

wants to merge 25 commits into from

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Mar 25, 2019 •
edited
Loading

Summary

Moved some directives to their "owner's" folder

  • infinite-scroll directive -> doc table
  • paginated-selectable-list -> ml
  • table_cell_filter -> paginated table
  • Check box -> watcher
  • Json input -> watcher
  • sortable column -> watcher
  • table info -> watcher
  • toggle button and panel -> watcher
  • kbn-tooltip -> watcher
  • partials -> directives/partials
  • debounce -> x-pack/hacks
  • dirty prompt -> deleted

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

Liza Katz and others added 12 commits March 20, 2019 19:03
Deleted
4409a39 
- progress
- bar
- progressbar

Changed
 - implementation of Discover > string field > proressbar to use EUI progressbar and tooltip.
added bug comment
7f798cc
@lizozom
Merge branch 'master' into new-platform-delete-progressbar
322ec3a
Moved send request button into consule_menu component
54cc8ee
Merge branch 'master' into new-platform-delete-progressbar
5a003f6
Fixed CR
9dc837b
Merge branch 'new-platform-delete-progressbar' of github.com:lizozom/…
5e39236 
…kibana into new-platform-delete-progressbar
Merge branch 'new-platform-delete-progressbar' into new-platform-kbn-…
70be7c0 
…tooltip
Moved directives used only by watcher to watecher folder
1f68253
watcher imports + delete dirty prompt
6144980
Moved debouce to xpack hacks
2b00eab
Moved ui/partials files -> ui/directives/partials folder
b3d3e3b
@lizozom lizozom self-assigned this Mar 25, 2019
@lizozom lizozom requested a review from a team as a code owner March 25, 2019 15:30
@lizozom lizozom requested a review from bmcconaghy March 25, 2019 15:30
@lizozom lizozom added Feature:New Platform Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.2.0 labels Mar 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

cchaos
cchaos approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SASS file rename LGTM

@stacey-gammon stacey-gammon mentioned this pull request Mar 25, 2019
Closed
94 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Mar 26, 2019

retest

@lizozom lizozom changed the title New platform move watcher deps New platform move deps Mar 26, 2019
@lizozom lizozom requested a review from a team as a code owner March 26, 2019 15:19
@elasticmachine
Copy link
Contributor

💔 Build Failed

peteharverson
peteharverson approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@lizozom
Copy link
Contributor Author

lizozom commented Mar 26, 2019

retest

@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Mar 28, 2019

PR contains corrupt merge

@lizozom lizozom closed this Mar 28, 2019
@lizozom lizozom added the chore label Mar 31, 2019
@lizozom lizozom deleted the new-platform-move-watcher-deps branch April 21, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@peteharverson peteharverson peteharverson approved these changes

@bmcconaghy bmcconaghy Awaiting requested review from bmcconaghy

Assignees

@lizozom lizozom

Labels
chore Feature:New Platform Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lizozom @elasticmachine @cchaos @peteharverson