Create unit test for registerBuiltInActionTypes and move common code #45648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YulNaumenko
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-stack-services |
💔 Build Failed |
mikecote
reviewed
Sep 13, 2019
💚 Build Succeeded |
pmuellr
approved these changes
Sep 13, 2019
|
|
||
| const ACTION_TYPE_ID = '.webhook'; | ||
| const configUtilsMock: ActionsConfigurationUtilities = { |
There was a problem hiding this comment.
nit; I think we can export the one in index.test.ts, and import it here; not a big deal, because if they diverge in the future I think we'd get some type errors and it would be obvious to fix it then; and it's only a test.
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Sep 16, 2019
…lastic#45648) * Create unit test for registerBuiltInActionTypes and move common code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created unit test for x-pack/legacy/plugins/actions/server/builtin_action_types/index.ts and move common code from each action type tests.
Fixes #45444