Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Converts index and saved search selection to React #47117

Merged
merged 4 commits into from
Oct 3, 2019
Merged

[ML] Converts index and saved search selection to React #47117

merged 4 commits into from
Oct 3, 2019

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Oct 2, 2019 •
edited
Loading

Summary

Part of #18374. Select index or search for Create Job Wizard.

image

Checklist

For maintainers

@darnautov darnautov requested review from a team as code owners October 2, 2019 13:28
@darnautov darnautov self-assigned this Oct 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

snide
snide approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sass files are deletes.

@peteharverson peteharverson changed the title [ML] index and saved search selection [ML] Convert index and saved search selection to React Oct 2, 2019
@peteharverson peteharverson changed the title [ML] Convert index and saved search selection to React [ML] Converts index and saved search selection to React Oct 2, 2019
walterra
walterra reviewed Oct 2, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great overall, nice to see so much angularjs code go! Just added some minor comments on e.g. translations.

.../ml/public/jobs/new_job/wizard/steps/index_or_search/__tests__/index_or_search_controller.js Show resolved Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/index_or_search/page.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/index_or_search/page.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/index_or_search/page.tsx Outdated Show resolved Hide resolved
jgowdyelastic
jgowdyelastic approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

walterra
walterra approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM 🎉

pheyos
pheyos approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally: all good. Test adjustment LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

peteharverson
peteharverson approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

@darnautov darnautov merged commit 9f3f14a into elastic:master Oct 3, 2019
@darnautov darnautov deleted the ML-18374-index-saved-search-selection branch October 3, 2019 08:59
@darnautov darnautov mentioned this pull request Oct 3, 2019
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Oct 3, 2019
@darnautov
[ML] Converts index and saved search selection to React (elastic#47117)
2ccd213 
* [ML] index and saved search selection

* [ML] fix i18m, PR remarks

* [ML] directive test

* [ML] fix job selection functional test
darnautov added a commit that referenced this pull request Oct 3, 2019
@darnautov
[ML] Converts index and saved search selection to React (#47117) (#47191
7179796 
)

* [ML] index and saved search selection

* [ML] fix i18m, PR remarks

* [ML] directive test

* [ML] fix job selection functional test
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 3, 2019
@jloleysens
Merge branch 'console-fix-menu-actions-alignment' of github.com:jlole…
db42ef0 
…ysens/kibana into console-fix-menu-actions-alignment

* 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits)
  [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865)
  [SIEM] hide siem data on empty string or _all (elastic#47166)
  [Uptime] Shim UI exports for new platform (elastic#44722)
  [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139)
  [Logs UI] Support partitioned log rate results in API (elastic#46751)
  [APM] Remove beta badge from transaction breakdown (elastic#47163)
  test: 💍 convert Interpreter font function tests to Jest (elastic#47193)
  visualizations 👉 NP-ready (elastic#47142)
  [Uptime] Update pings chart colors (elastic#46780)
  Add scroll into view to avoid tooltip overlap (elastic#47106)
  Variety of quick a11y fixes (elastic#46569)
  [Graph] Empty workspace overlay (elastic#45547)
  [ML] Converts index and saved search selection to React (elastic#47117)
  [Uptime] Change default status filter in ping list to all on monitor page  (elastic#47108)
  refactor: 💡 convert Interpreter .js -> .ts (elastic#44545)
  Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125)
  chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091)
  [SIEM] Update Settings Text (elastic#47147)
  Add KQL functionality in the find function of the saved objects (elastic#41136)
  [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@snide snide snide approved these changes

@pheyos pheyos pheyos approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@darnautov darnautov

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@darnautov @elasticmachine @walterra @snide @pheyos @peteharverson @jgowdyelastic