[Logs UI / Metrics UI] New Platform migration server followups #51615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
Kerry350
added
v7.6.0
v8.0.0
Feature:Logs UI
sorenlouv
approved these changes
Dec 9, 2019
simianhacker
requested changes
Dec 11, 2019
There was a problem hiding this comment.
Everything looks good. The only thing that stuck out to me is around the aggregation type. It seems like we are defining that list several times so I added some suggestions to try and reduce that some. If you want to just move forward with what you have, just submit for review again and I will approve.
x-pack/legacy/plugins/infra/public/components/metrics_explorer/aggregation.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/infra/common/http_api/metrics_explorer/index.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/infra/public/components/metrics_explorer/aggregation.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/infra/public/components/metrics_explorer/aggregation.tsx
Outdated
Show resolved
Hide resolved
jasonrhodes
approved these changes
Dec 12, 2019
jasonrhodes
reviewed
Dec 12, 2019
| @@ -54,10 +54,6 @@ export function getApmIndicesConfig(config: APMConfig): ApmIndicesConfig { | |||
| }; | |||
| } | |||
|
|
|||
| // export async function getApmIndices(context: APMRequestHandlerContext) { | |||
There was a problem hiding this comment.
lol sorry, I think this was my fault -- thanks for the clean up :) <3
|
@simianhacker Thanks for the review and suggestions. I was going to do these in a followup, but they didn't take very long so I've added them in 2139171. If you're happy and can approve I'll merge this 👍 |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Dec 17, 2019
Kerry350
added a commit
that referenced
this pull request
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is currently a WIP, but open for visibility.This is a followup PR to #45299, and contains changes that were important, but not blockers in getting the other PR merged.
setup()method return statement (a918f08) (This isn't used yet, but it just gets us ready for when we move 100% to the NP world / directory).kibanaVersionproperty to thekibana.jsonmanifest for the Infra plugin (b9cb4ee).The changeset here looks a lot bigger than it realistically is. The vast majority of the changes relate to the io-ts conversion for Metrics Explorer. As some of the enums have changed to string unions a lot of files were touched, but for minimal changes.
For testing this PR, please ensure the Metrics portions of the UI still work as expected.
(@elastic/apm-ui have been automatically requested for review as I've removed a comment from an APM file that we left behind in the big migration PR.)