Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace 'change' to arrow in index pattern selector #51954

Merged
merged 4 commits into from
Dec 2, 2019
Merged

refactor: replace 'change' to arrow in index pattern selector #51954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e04d0de
refactor: replace change to arrow in index pattern selector
mbondyra Dec 2, 2019
ee9cc07
chore: translations removed
mbondyra Dec 2, 2019
8183e72
Merge branch 'master' into IS-51910_replace-change-to-arrow-in-index-…
elasticmachine Dec 2, 2019
fcb4e07
feat: added aria label
mbondyra Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions ..._plugins/kibana/public/discover/components/field_chooser/discover_index_pattern_title.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import React from 'react';
import { EuiToolTip, EuiFlexItem, EuiFlexGroup, EuiTitle, EuiButtonEmpty } from '@elastic/eui';

import { FormattedMessage } from '@kbn/i18n/react';

import { i18n } from '@kbn/i18n';
export interface DiscoverIndexPatternTitleProps {
/**
* determines whether the change link is displayed
Expand Down Expand Up @@ -65,18 +65,19 @@ export function DiscoverIndexPatternTitle({
}
>
<EuiButtonEmpty
aria-label={i18n.translate(
'kbn.discover.fieldChooser.indexPattern.changeLinkAriaLabel',
{
defaultMessage: 'Change current index pattern',
}
)}
data-test-subj="indexPattern-switch-link"
size="xs"
onClick={() => onChange()}
>
(
<FormattedMessage
id="kbn.discover.fieldChooser.indexPattern.changeLinkLabel"
defaultMessage="change"
description="should be a short word since lack of space"
/>
)
</EuiButtonEmpty>
iconSide="right"
iconType="arrowDown"
color="text"
/>
</EuiToolTip>
</EuiFlexItem>
)}
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2492,8 +2492,8 @@
"kbn.context.olderDocumentsWarning": "アンカーよりも古いドキュメントは {docCount} 件しか見つかりませんでした。",
"kbn.context.olderDocumentsWarningZero": "アンカーよりも古いドキュメントは見つかりませんでした。",
"kbn.discover.fieldChooser.fieldFilterFacetButtonLabel": "フィルタリングされたフィールド",
"kbn.discover.fieldChooser.indexPattern.changeLinkLabel": "変更",
"kbn.discover.fieldChooser.indexPattern.changeLinkTooltip": "現在のインデックスパターンを変更",
"kbn.discover.fieldChooser.indexPattern.changeLinkAriaLabel": "現在のインデックスパターンを変更",
"kbn.discover.fieldChooser.searchPlaceHolder": "検索フィールド",
"kbn.discover.histogram.partialData.bucketTooltipText": "選択された時間範囲にはこのバケット全体は含まれていませんが、一部データが含まれている可能性があります。",
"kbn.doc.failedToLocateIndexPattern": "ID {indexPatternId} に一致するインデックスパターンがありません",
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2493,8 +2493,8 @@
"kbn.context.olderDocumentsWarning": "仅可以找到 {docCount} 个比定位标记旧的文档。",
"kbn.context.olderDocumentsWarningZero": "找不到比定位标记旧的文档。",
"kbn.discover.fieldChooser.fieldFilterFacetButtonLabel": "已筛选字段",
"kbn.discover.fieldChooser.indexPattern.changeLinkLabel": "更改",
"kbn.discover.fieldChooser.indexPattern.changeLinkTooltip": "更改当前索引模式",
"kbn.discover.fieldChooser.indexPattern.changeLinkAriaLabel": "更改当前索引模式",
"kbn.discover.fieldChooser.searchPlaceHolder": "搜索字段",
"kbn.discover.histogram.partialData.bucketTooltipText": "选定的时间范围不包括此整个存储桶，其可能包含部分数据。",
"kbn.doc.failedToLocateIndexPattern": "无索引模式匹配 ID {indexPatternId}",
Expand Down