[SIEM] Alerts view - adding alerts table #51959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
|
💔 Build Failed |
|
Pinging @elastic/siem (Team:SIEM) |
XavierM
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/components/alerts_viewer/alerts_table.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Dec 17, 2019
XavierM
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/components/events_viewer/index.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/pages/hosts/details/details_tabs.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/pages/hosts/details/index.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Dec 17, 2019
XavierM
reviewed
Dec 17, 2019
XavierM
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/pages/hosts/navigation/alerts_query_tab_body.tsx
Show resolved
Hide resolved
XavierM
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/pages/network/navigation/types.ts
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Dec 17, 2019
XavierM
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/pages/hosts/navigation/types.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
XavierM
approved these changes
Dec 18, 2019
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Dec 18, 2019
* add alert view to hosts page * add defaultHeaders * add alerts table * fix dsl query * add alerts histogram * add i18n for alerts table * fix types error * fix type issue * whitespace cleanup * fix types * fix types * fix types * fix types * fix types * rename params * fix unit test * fix types * revert change on updateHostsSort * remove unused prop * update unit test * pair programming with angela to get filter working * update alerts query * clean up * fix queries * align type for pageFilters * apply page filter for network page * simplify filter props for alerts view * clean up * replace hard coded tab name
angorayc
added a commit
that referenced
this pull request
Dec 18, 2019
* add alert view to hosts page * add defaultHeaders * add alerts table * fix dsl query * add alerts histogram * add i18n for alerts table * fix types error * fix type issue * whitespace cleanup * fix types * fix types * fix types * fix types * fix types * rename params * fix unit test * fix types * revert change on updateHostsSort * remove unused prop * update unit test * pair programming with angela to get filter working * update alerts query * clean up * fix queries * align type for pageFilters * apply page filter for network page * simplify filter props for alerts view * clean up * replace hard coded tab name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#51016
This PR has some dependency between #53101,
either may need some update once the other is merged.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately