Fix import causing Kibana to crash in IE11.

[lukeelmers]

Closes #50927

A regression was caused by the changes in #50182, where some client-side code appeared to be indirectly importing some server-side utilities from the data plugin src/plugins/data/server.

This caused a bunch of additional code to be bundled in the commons.bundle.js, which when executed from IE11, caused a syntax error. (I actually never got to what the specific syntax error was in my investigation, as I was primarily focused on getting rid of the server-side code that was being bundled with everything).

Turns out that some of the Canvas common functions (in this case, saved_map) which are loaded from the browser, are relying on a buildEmbeddableFilters method which is located in the Canvas server lib. This imports some stuff from src/plugins/data/server, which is how the code ended up in the common bundle to begin with.

That said, I believe the changes introduced in #50182 were actually correct: server files should be able to import static code from other server files. The temporary workaround here was to import from src/plugins/data/common, but the real fix is figuring out whether the pieces of buildEmbeddableFilters needed by the client-side code could be split out. I've created #52343 to track this work.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 7fec835

[Dosant]

Awesome! Thanks!

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[lukeelmers]

Also cc @elastic/kibana-platform -- If it were possible to have linter rules to catch these sorts of bad imports that inadvertently cross server/client boundaries, it would help eliminate a whole category of bugs we have been seeing during the migration process. Not sure how feasible that would be to implement, but wanted to mention it here.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f4d650e

[Dosant]

Checked that can now launch Kibana in IE11

[mshustov]

@lukeelmers as I can see x-pack/legacy/plugins/canvas/server/lib/build_embeddable_filters.ts is supposed to contain server code. It's rather interesting why it's imported from files under the common folder.
You can add this check in eslintrc file

{
  target: ['**/common/**/*'],
  from: ['**/server/**/*', '**/public/**/*'],
  errorMessage: 'Common code cannot import env-dependent code',
},

and it shows 265 problems in the current codebase.

[kertal]

IE11 is happy again 🌻 !

[joshdover]

Also cc @elastic/kibana-platform -- If it were possible to have linter rules to catch these sorts of bad imports that inadvertently cross server/client boundaries, it would help eliminate a whole category of bugs we have been seeing during the migration process. Not sure how feasible that would be to implement, but wanted to mention it here.

Just put up a PR here: #52447
We'll have to see how many violations we already have on CI, couldn't get eslint to finish in a reasonable time on my machine.

[pgayvallet]

refers to #49053

[alexwizp]

Thank you!

[kertal]

@elasticmachine merge upstream

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 00ab512

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[crob611]

Looks good to me