Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a list of breaking changes in licensing plugin readme #53574

Merged
merged 3 commits into from
Dec 19, 2019

Conversation

mshustov
Copy link
Contributor

Summary

Closes #18356
Provides a list of breaking changes in the licensing plugins readme.d
[skip-ci]

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Dec 19, 2019
@mshustov mshustov requested a review from a team as a code owner December 19, 2019 11:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth adding a table of contents just to be sure people don't miss the breaking changes at the bottom of the document.

x-pack/plugins/licensing/README.md Outdated Show resolved Hide resolved
x-pack/plugins/licensing/README.md Outdated Show resolved Hide resolved
x-pack/plugins/licensing/README.md Outdated Show resolved Hide resolved
@mshustov mshustov requested a review from rudolf December 19, 2019 14:30
@mshustov mshustov merged commit dd1faba into elastic:master Dec 19, 2019
@mshustov mshustov deleted the licensing-add-breaking-changes branch December 19, 2019 14:50
mshustov added a commit to mshustov/kibana that referenced this pull request Dec 19, 2019
…c#53574)

* provide a list of breaking changes in licensing plugin

* Apply suggestions from code review

Co-Authored-By: Rudolf Meijering <[email protected]>

* add ToC
mshustov added a commit that referenced this pull request Dec 19, 2019
#53595)

* provide a list of breaking changes in licensing plugin

* Apply suggestions from code review

Co-Authored-By: Rudolf Meijering <[email protected]>

* add ToC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License plugin
3 participants