Migrate Management views to Kibana Platform plugin

src/core/public/saved_objects/saved_objects_client.test.ts

@@ -448,23 +448,4 @@ describe('SavedObjectsClient', () => {
  `);
  });
  });
-
- it('maintains backwards compatibility by transforming http.fetch errors to be compatible with kfetch errors', () => {
- const err = {
- response: { ok: false, redirected: false, status: 409, statusText: 'Conflict' },
- body: 'response body',
- };
- http.fetch.mockRejectedValue(err);
- return expect(savedObjectsClient.get(doc.type, doc.id)).rejects.toMatchInlineSnapshot(`
- Object {
- "body": "response body",
- "res": Object {
- "ok": false,
- "redirected": false,
- "status": 409,
- "statusText": "Conflict",
- },
- }
- `);
- });
 });

src/core/public/saved_objects/saved_objects_client.ts

@@ -465,11 +465,7 @@ export class SavedObjectsClient {
  * uses `{response: {status: number}}`.
  */
  private savedObjectsFetch(path: string, { method, query, body }: HttpFetchOptions) {
- return this.http.fetch(path, { method, query, body }).catch(err => {
- const kfetchError = Object.assign(err, { res: err.response });
- delete kfetchError.response;
- return Promise.reject(kfetchError);
- });
+ return this.http.fetch(path, { method, query, body });
  }
 }
 

src/plugins/management/public/index.ts

@@ -24,7 +24,12 @@ export function plugin(initializerContext: PluginInitializerContext) {
  return new ManagementPlugin();
 }
 
-export { ManagementSetup, ManagementStart, RegisterManagementApp } from './types';
+export {
+ ManagementSetup,
+ ManagementStart,
+ RegisterManagementApp,
+ RegisterManagementAppArgs,
+} from './types';
 export { ManagementApp } from './management_app';
 export { ManagementSection } from './management_section';
 export { ManagementSidebarNav } from './components'; // for use in legacy management apps

x-pack/legacy/plugins/security/index.d.ts

@@ -5,7 +5,7 @@
  */
 
 import { Legacy } from 'kibana';
-import { AuthenticatedUser } from './common/model';
+import { AuthenticatedUser } from '../../../plugins/security/public';
 
 /**
  * Public interface of the security plugin.

x-pack/legacy/plugins/security/index.js

@@ -40,8 +40,6 @@ export const security = kibana =>
  },
 
  uiExports: {
- chromeNavControls: [],
- managementSections: ['plugins/security/views/management'],
  styleSheetPaths: resolve(__dirname, 'public/index.scss'),
  apps: [
  {
@@ -76,7 +74,6 @@ export const security = kibana =>
  'plugins/security/hacks/on_unauthorized_response',
  'plugins/security/hacks/register_account_management_app',
  ],
- home: ['plugins/security/register_feature'],
  injectDefaultVars: server => {
  const securityPlugin = server.newPlatform.setup.plugins.security;
  if (!securityPlugin) {

x-pack/legacy/plugins/security/public/index.scss

@@ -15,3 +15,6 @@ $secFormWidth: 460px;
 // Public views
 @import './views/index';
 
+// Styles of Kibana Platform plugin
+@import '../../../../plugins/security/public/index';
+