Fix TSVB rollup integration #56525
Merged
Fix TSVB rollup integration #56525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
added
Feature:TSVB
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
timroes
approved these changes
Feb 3, 2020
alexwizp
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56147
This PR fixes the rollup TSVB integration in 7.6. TSVB requests are already handled by the new platform and create an incomplete request facade to appear like legacy requests to plugins. Rollup uses a property of the legacy request object that's not available on the facade.
By spreading in the NP request object into the facade and using the NP api to create the elasticsearch client in the rollup plugin, the rollup search strategy can make requests using =NP apis. The additional properties on the request facade are not used by the default strategy.
Requests passed in from the infra server do not include the requests and can't issue rollup requests, but AFAIK this isn't used at the moment.
Field requests don;'t have this problem because they are still completely handled by the legacy platform