Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - stabilize job row and analytics result view assertions #56595

Merged
merged 2 commits into from
Feb 4, 2020
Merged

[ML] Functional tests - stabilize job row and analytics result view assertions #56595

merged 2 commits into from
Feb 4, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Feb 3, 2020 •
edited
Loading

Summary

This PR makes assertions of the job row and analytics result views more robust against loading time issues during test execution.

Fixes #50010

@pheyos pheyos self-assigned this Feb 3, 2020
@pheyos
Copy link
Member Author

pheyos commented Feb 3, 2020 •
edited
Loading

Checking test stability in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/161/ ...
Passed 39x (1 unrelated discover test failure)

@pheyos
Copy link
Member Author

pheyos commented Feb 3, 2020 •
edited
Loading

Checking test stability again in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/162/ ...
Passed 36x. 4 timing failures for analytics result views, I'll increase the timeout.

@pheyos
Copy link
Member Author

pheyos commented Feb 3, 2020 •
edited
Loading

Checking test stability again in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/163/ ...
Passed 38x (2 unrelated discover and dashboard failures)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos
Copy link
Member Author

pheyos commented Feb 4, 2020 •
edited
Loading

Checking test stability again in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/164/ ...
Passed 40x

@pheyos
Copy link
Member Author

pheyos commented Feb 4, 2020 •
edited
Loading

Checking test stability again in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/165/ ...
Passed 39x (1 unrelated discover failure)

@pheyos pheyos changed the title [ML] Functional tests - stabilize job row assertion [ML] Functional tests - stabilize job row and analytics result view assertions Feb 4, 2020
@pheyos
Copy link
Member Author

pheyos commented Feb 4, 2020

Summary
ML tests seem to be stable with the changes in this PR (no ML failure in 120 CI runs).

@pheyos pheyos added the :ml label Feb 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos marked this pull request as ready for review February 4, 2020 12:20
@pheyos pheyos requested a review from a team as a code owner February 4, 2020 12:20
@pheyos pheyos added release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.6.1 v7.7.0 v8.0.0 labels Feb 4, 2020
peteharverson
peteharverson approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit 4f26741 into elastic:master Feb 4, 2020
@pheyos pheyos deleted the stabilize_job_table_check branch February 4, 2020 15:08
@pheyos pheyos mentioned this pull request Feb 4, 2020
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Feb 4, 2020
@pheyos
[ML] Functional tests - stabilize job row and analytics result view a…
3e2c282 
…ssertions (elastic#56595)

This PR makes assertions of the job row and analytics result views more robust against loading time issues during test execution.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 4, 2020
@gmmorris
Merge branch 'master' into alerting/get-alert-state
28e7c7e 
* master: (42 commits)
  Move kuery_autocomplete ⇒ NP (elastic#56607)
  [ML] Functional tests - stabilize job row and analytics result view assertions (elastic#56595)
  [Discover] Inline angular directives only used in this plugin (elastic#56119)
  [Discover] Migrate get_sort.js test from mocha to TypeScript (elastic#56011)
  [SIEM] Enable flow_target_select_connected unit tests (elastic#55618)
  Start consuming np logging config (elastic#56480)
  [SIEM] Add eslint-plugin-react-perf (elastic#55960)
  Mention changed SAML ACS endpoint URL in breaking changes doc. (elastic#56613)
  Add `getServerInfo` API to http setup contract (elastic#56636)
  Updates Monitoring alert Jest snapshots
  Kibana property config migrations (elastic#55937)
  Vislib replacement toggle (elastic#56439)
  [Uptime] Add unit tests for QueryContext time calculation (elastic#56671)
  [SIEM][Detection Engine] Critical blocker, fixes pre-packaged rule miscounts
  Upgrade EUI to v18.3.0 (elastic#56228)
  [Maps] Fix server log (elastic#56679)
  [SIEM] Fixes FTUE when APM node is present (elastic#56574)
  [Reporting/FieldFormats] expose `setFieldFormats` and call from ReportingPlugin.start (elastic#56563)
  Update EMS API urls for production (elastic#56657)
  Ability to delete alerts even when AAD is out of sync (elastic#56543)
  ...
pheyos added a commit that referenced this pull request Feb 4, 2020
@pheyos
[ML] Functional tests - stabilize job row and analytics result view a…
27e58b5 
…ssertions (#56595) (#56751)

This PR makes assertions of the job row and analytics result views more robust against loading time issues during test execution.
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Feb 10, 2020
@pheyos
[ML] Functional tests - stabilize job row and analytics result view a…
fc7ff2e 
…ssertions (elastic#56595)

This PR makes assertions of the job row and analytics result views more robust against loading time issues during test execution.
pheyos added a commit to pheyos/kibana that referenced this pull request Feb 12, 2020
@pheyos
[ML] Functional tests - stabilize job row assertion (elastic#56595)
bda88fd 
This PR makes assertion of the job row more robust against loading time issues during test execution.
@pheyos pheyos mentioned this pull request Feb 12, 2020
Merged
pheyos added a commit that referenced this pull request Feb 12, 2020
@pheyos
[ML] Functional tests - stabilize job row assertion (#56595) (#57420)
20a3a14 
This PR makes assertion of the job row more robust against loading time issues during test execution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@pheyos pheyos

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.6.1 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@pheyos @kibanamachine @elasticmachine @peteharverson