Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Consume core startup services #57259

Merged
merged 1 commit into from
Feb 11, 2020
Merged

[Uptime] Consume core startup services #57259

merged 1 commit into from
Feb 11, 2020

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #57251.

We need to access the licensing plugin; this PR leverages core.getStartServices so we can access license information in our plugin.

Checklist

Delete any items that are not applicable to this PR.

There should be no delta in application behavior.

For maintainers

@justinkambic justinkambic added v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 labels Feb 10, 2020
@justinkambic justinkambic self-assigned this Feb 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label Feb 10, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31
shahzad31 approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@shahzad31 shahzad31 merged commit c383f50 into elastic:master Feb 11, 2020
@justinkambic justinkambic mentioned this pull request Feb 11, 2020
Merged
justinkambic added a commit that referenced this pull request Feb 11, 2020
@justinkambic
Consume core startup services. (#57259) (#57314)
f5251bb
@justinkambic
Copy link
Contributor Author

Backported to: f5251bb
#57314

@justinkambic justinkambic deleted the uptime_consume-setup-instead-of-start branch February 11, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@justinkambic justinkambic

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] Plugin cannot reference the licensing plugin
4 participants
@justinkambic @elasticmachine @kibanamachine @shahzad31