Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async search observable can return a non-final response #64132 #64155

Merged
merged 4 commits into from
Apr 22, 2020
Merged

Async search observable can return a non-final response #64132 #64155

merged 4 commits into from
Apr 22, 2020

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Apr 22, 2020

Summary

Resolves #64132

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lizozom lizozom added bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 22, 2020
@lizozom lizozom requested a review from a team as a code owner April 22, 2020 10:21
@lizozom lizozom self-assigned this Apr 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

jimczi
jimczi approved these changes Apr 22, 2020
View reviewed changes
Copy link

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ;).

streamich
streamich approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM.

x-pack/plugins/data_enhanced/public/search/async_search_strategy.ts Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit a80348e into elastic:master Apr 22, 2020
@lizozom lizozom mentioned this pull request Apr 22, 2020
Merged
lizozom pushed a commit to lizozom/kibana that referenced this pull request Apr 22, 2020
Async search observable can return a non-final response elastic#64132 (…
4da10aa 
…elastic#64155)

* resolves elastic#64132

* simplify condition

* added IAsyncSearchResponse type

* update and add jest tests
@lizozom lizozom mentioned this pull request Apr 22, 2020
Merged
lizozom pushed a commit to lizozom/kibana that referenced this pull request Apr 22, 2020
Async search observable can return a non-final response elastic#64132 (…
c646e58 
…elastic#64155)

* resolves elastic#64132

* simplify condition

* added IAsyncSearchResponse type

* update and add jest tests
@nreese
Copy link
Contributor

nreese commented Apr 22, 2020

@lizozom Can you provide a little more details about how this fixes the problem and what the problem is? I want to verify that consumers of SearchSource do not need to do anything different and this was a problem with the service.

@lizozom
Copy link
Contributor Author

lizozom commented Apr 22, 2020

@nreese the problem here was not handling an error state returned by ES properly.
There was a case where ES doesn't return results, but we would assume that data should still be arriving. Hence we would poll until we tiemout.

@nreese
Copy link
Contributor

nreese commented Apr 22, 2020

So clients of SearchSource to not need to do anything special. Does SearchSource return partial results? How should clients handle that?

lizozom pushed a commit that referenced this pull request Apr 22, 2020
Async search observable can return a non-final response #64132 (#64155)…
d2b9b69 
… (#64196)

* resolves #64132

* simplify condition

* added IAsyncSearchResponse type

* update and add jest tests
lizozom pushed a commit that referenced this pull request Apr 22, 2020
Async search observable can return a non-final response #64132 (#64155)…
c9375a5 
… (#64195)

* resolves #64132

* simplify condition

* added IAsyncSearchResponse type

* update and add jest tests
@kertal kertal mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@jimczi jimczi jimczi approved these changes

Assignees

@lizozom lizozom

Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async search observable can return a non-final response
6 participants
@lizozom @elasticmachine @kibanamachine @nreese @streamich @jimczi