Converted vis_type_tagcloud to Typescript #63592 fix #64747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
flash1293
reviewed
May 6, 2020
flash1293
reviewed
May 6, 2020
flash1293
reviewed
May 6, 2020
flash1293
reviewed
May 6, 2020
| linear: () => d3.scale.linear(), | ||
| log: () => d3.scale.log(), | ||
| 'square root': () => d3.scale.sqrt(), | ||
| }; | ||
|
|
||
| export class TagCloud extends EventEmitter { | ||
| constructor(domNode, colorScale) { | ||
| _element: HTMLElement; | ||
| _d3SvgContainer: any; |
There was a problem hiding this comment.
This can be typed strictly
There was a problem hiding this comment.
Have issues with setting type on _d3SvgContainer
flash1293
reviewed
May 6, 2020
flash1293
reviewed
May 6, 2020
flash1293
reviewed
May 6, 2020
flash1293
reviewed
May 6, 2020
|
@arjunvijayanathakurup There are still a lot of The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converted vis_type_tagcloud from JavaScript to TypeScript.
Issue #63592 fixed