Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.8] Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) #67361

Closed
wants to merge 2 commits into from

Conversation

YulNaumenko
Copy link
Contributor

Backports the following commits to 7.8:

…ic#65936)

* Changed actions API endpoints urls to follow Kibana STYLEGUIDE

* Fixed tests

* fixed test

* fixed test

* resolved conflicts

* Fixed siem tests

* Fixed failing test

* fixed readme and test

* Changed actions api urls to follow the template 'api/{plugin}/{type}/{id}

* Fixed type checks

* Fixed tests and API

* fixed tests

* Fixed type checks

* fixed type check
# Conflicts:
#	x-pack/plugins/siem/public/cases/containers/api.test.tsx
#	x-pack/plugins/siem/public/cases/containers/api.ts
#	x-pack/test/case_api_integration/basic/tests/cases/push_case.ts
@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/siem/public/containers/case.Case Configuration API getActionLicense check url, method, signal

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

- Expected
+ Received

- "/api/action/types",
+ "/api/actions/list_action_types",
  {"method": "GET", "signal": {}},

Number of calls: 1
    at Object.test (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/siem/public/containers/case/api.test.tsx:91:25)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/siem/public/containers/case.Case Configuration API pushToService check url, method, signal

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

- Expected
+ Received

- "/api/action/connectorId/_execute",
+ "/api/actions/connectorId/_execute",
  {"body": "{\"params\":{\"subAction\":\"pushToService\",\"subActionParams\":{\"actionBy\":{\"fullName\":\"Leslie Knope\",\"username\":\"lknope\",\"email\":\"[email protected]\"},\"caseId\":\"basic-case-id\",\"createdAt\":\"2020-02-19T23:06:33.798Z\",\"createdBy\":{\"fullName\":\"Leslie Knope\",\"username\":\"lknope\",\"email\":\"[email protected]\"},\"externalId\":null,\"title\":\"what a cool value\",\"commentId\":null,\"updatedAt\":\"2020-02-19T23:06:33.798Z\",\"updatedBy\":{\"fullName\":\"Leslie Knope\",\"username\":\"lknope\",\"email\":\"[email protected]\"},\"description\":\"nice\",\"comments\":null}}}", "method": "POST", "signal": {}},

Number of calls: 1
    at Object.test (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/siem/public/containers/case/api.test.tsx:419:25)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants