-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data plugin] Add configuration property to enable / disable autocomplete #67847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-app-arch (Team:AppArch) |
@elasticmachine merge upstream |
It seems we removed this setting by mistake in 7.7, so I think this is a bug fix. In fact I think it's even worthy of patching 7.7 |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lizozom
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jun 4, 2020
…lete (elastic#67847) Co-authored-by: Elastic Machine <[email protected]>
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jun 4, 2020
…lete (elastic#67847) Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jun 4, 2020
…lete (elastic#67847) Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # src/plugins/data/public/plugin.ts # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jun 4, 2020
…lete (elastic#67847) Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jun 4, 2020
…lete (elastic#67847) Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # src/plugins/data/public/plugin.ts # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jun 4, 2020
…lete (elastic#67847) Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md
alexwizp
added a commit
that referenced
this pull request
Jun 4, 2020
…lete (#67847) (#68222) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
alexwizp
added a commit
that referenced
this pull request
Jun 4, 2020
…lete (#67847) (#68224) Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # src/plugins/data/public/plugin.ts # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md
alexwizp
added a commit
that referenced
this pull request
Jun 4, 2020
…lete (#67847) (#68223) Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 4, 2020
* master: (26 commits) [Console]remove completion for type for filter queries and aggs (elastic#68103) [ML] Transforms: Filter aggregation support (elastic#67591) [ES UI Shared] Monaco XJSON (elastic#67485) [Index Management] Add data streams functionality to indices tab (elastic#67940) [Discover] Fix renaming of saved search not displayed in breadcrumb (elastic#67577) [SECURITY] Rename siem plugin to security_solution (elastic#67902) [Uptime] Fix Telemetry Api flaky test (elastic#67358) [Data plugin] Add configuration property to enable / disable autocomplete (elastic#67847) remove scripts. prettire update has been done (elastic#68130) Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198) [apm] docs: add deployment annotation example (elastic#67408) [ML] Extend population preview chart to show actual and typical value (elastic#67569) Refactor index management client integration tests for scalability (elastic#67917) Add generator function that creates multiple alerts (elastic#67713) chore(NA): remove config arg from os packages (elastic#67871) [Reporting] Move code out of Legacy (elastic#67904) [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125) [Security] [Cases] Manage timeline UI API (elastic#67719) [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234) Fix code coverage for jest, upload merged reports (elastic#68149) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: #67841
Summary
[Data plugin]
Add configuration property to enable / disable autocompleteDev docs
[Data plugin]
AutocompleteTwo new configuration properties were added to
enable/disable
autocomplete functionalityChecklist
Delete any items that are not applicable to this PR.
For maintainers