Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] collect number of visualization saved in the past 7, 30 and 90 days #67865

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jun 1, 2020

Summary

Fixes #57847

We want to also add to each visualization stats the number of visualizations saved the last 30 and the last 90 days.
Right now we collect the stats with the following format:
"visualization_types": { "input_control_vis": { "total": 3, "spaces_min": 3, "spaces_max": 3, "spaces_avg": 3 }, "area": { "total": 4, "spaces_min": 4, "spaces_max": 4, "spaces_avg": 4 },

and with this change is going to also collect the number of visualizations for the past 30 and 90 days:
"visualization_types": { "input_control_vis": { "total": 3, "spaces_min": 3, "spaces_max": 3, "spaces_avg": 3, "saved_30_days_total": 2, "saved_90_days_total": 3, }, "area": { "total": 4, "spaces_min": 4, "spaces_max": 4, "spaces_avg": 4, "saved_30_days_total": 2, "saved_90_days_total": 4, },

How to test it:

  1. Go to Dev Tools and remove all the tasks
    POST /.kibana_task_manager/_delete_by_query { "query": { "match_all": {} } }

  2. Make a change to a server file in kibana (add an empty space for example)

  3. Go to Management-->Advanced Setting->Telemetry-->See an example of what we collect

Elastic

Check the visualization types field, it should contain the new values.

Checklist

@stratoula stratoula force-pushed the telemetry-vis-save-past-days branch from 4c4da4e to a617066 Compare June 1, 2020 14:52
@stratoula stratoula changed the title Telemetry vis save past days [Telemetry] number of visualization saved in the past 30 and 90 days Jun 1, 2020
@stratoula stratoula force-pushed the telemetry-vis-save-past-days branch 5 times, most recently from a1cce3b to 3d98ded Compare June 3, 2020 07:37
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula changed the title [Telemetry] number of visualization saved in the past 30 and 90 days [Telemetry] collect number of visualization saved in the past 30 and 90 days Jun 3, 2020
@stratoula stratoula self-assigned this Jun 3, 2020
@stratoula stratoula added Feature:Telemetry Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.9.0 v8.0.0 labels Jun 3, 2020
@stratoula stratoula marked this pull request as ready for review June 4, 2020 07:18
@stratoula stratoula added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula requested a review from a team June 4, 2020 07:19
@TinaHeiligers TinaHeiligers requested a review from a team June 4, 2020 14:46
@TinaHeiligers
Copy link
Contributor

@stratoula I added the Kibana telemetry team as reviewers.

@stratoula
Copy link
Contributor Author

stratoula commented Jun 4, 2020

Thank you @TinaHeiligers!

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I simply added some minor NITs in case you want to consider them! Great work! :)

@stratoula stratoula force-pushed the telemetry-vis-save-past-days branch from eeba6ec to dfc0915 Compare June 4, 2020 16:26
@stratoula stratoula changed the title [Telemetry] collect number of visualization saved in the past 30 and 90 days [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days Jun 4, 2020
@stratoula stratoula requested review from flash1293 and wylieconlon and removed request for a team June 5, 2020 13:23
@flash1293
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM

@stratoula stratoula removed the request for review from wylieconlon June 8, 2020 07:40
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit fcab974 into elastic:master Jun 8, 2020
stratoula added a commit to stratoula/kibana that referenced this pull request Jun 8, 2020
…nd 90 days (elastic#67865)

* Update telemetry for visualizations to also count the vis from the past 30 and 90 days

* Also add metrics for the saved visualizations for the past 7 days

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 8, 2020
* master:
  [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305)
  [security_solution] enable react-hooks/exhaustive-deps (elastic#68470)
  Closes elastic#66867 by adding missing, requried API params (elastic#68465)
  [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865)
  [Logs UI] View in context tweaks (elastic#67777)
  Kibana developer examples landing page (elastic#67049)
  Bump decompress package version (elastic#68386)
  fix elastic#66185 (elastic#66186)
  Bump pdfmake package version (elastic#68395)
  Unskip embeddables/adding_children suite (elastic#68111)
  Add embed mode options in the Share UI (elastic#58435)
  Adding key to avoid react warning (elastic#68491)
stratoula added a commit that referenced this pull request Jun 8, 2020
…nd 90 days (#67865) (#68520)

* Update telemetry for visualizations to also count the vis from the past 30 and 90 days

* Also add metrics for the saved visualizations for the past 7 days

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@rashmivkulkarni
Copy link
Contributor

tested on BC2- 7.9.0 - works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry] number of visualization saved in the past 90 days
7 participants