[wip] URL drilldown #68235
[wip] URL drilldown #68235
Conversation
Dosant
changed the title
x-pack/plugins/advanced_ui_actions/public/drilldowns/url_drilldown/url_drilldown_definition.tsx
Outdated
Show resolved
Hide resolved
Dosant
changed the title
Dosant
changed the title
x-pack/plugins/ui_actions_enhanced/public/actions/action_enhanced.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,104 @@ | |||
| /* | |||
There was a problem hiding this comment.
I would split the action license support into its own dedicated PR. To ensure the new APIs are used (and tested), you could modify one of the examples, or add a new one.
There was a problem hiding this comment.
@stacey-gammon, oh, forgot to remove reviewers from this pr. this is a cleaned up version of just license support: #68507
Dosant
force-pushed
the
dev/url-drilldown
branch
from
7b69269
to
644fc50
Compare
|
I will put it on our list to create a description list UI for that variable popover |
| const filtersFromEvent = await (async () => { | ||
| try { | ||
| if (isRangeSelectTriggerContext(context)) | ||
| return await createFiltersFromRangeSelectAction(context.data); |
There was a problem hiding this comment.
as mentioned in the doc, i would prefer if we would not postprocess context.data and expose it directly. it will give more power to the user and it will be easier to extend url drilldown with future triggers.
…down # Conflicts: # x-pack/plugins/ui_actions_enhanced/public/drilldowns/index.ts
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
Summary
URL Drilldown
issue
spec
Reusability considerations:
This is not actually
Url Drilldown, butSomeEmbeddablesToUrlDrilldown, as it relies onembeddablein drilldown context and on support ofValueClickTrigger&RangeSelectTrigger. This where url drilldown gets variables from from a tempate. More details here: specThis
EmbeddableToUrlDrilldownis registered inembeddable_enhancedplugin. But reusable building block to build other url Drilldowns are inuiActions_enhanced. How to use them showcased inSampleUrlDrilldownexample.