[Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… #69345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
added
v8.0.0
release_note:skip
…y-use-global-time-hook # Conflicts: # x-pack/plugins/security_solution/public/alerts/components/alerts_histogram_panel/index.tsx # x-pack/plugins/security_solution/public/alerts/pages/detection_engine/detection_engine.tsx # x-pack/plugins/security_solution/public/alerts/pages/detection_engine/rules/details/index.tsx # x-pack/plugins/security_solution/public/common/components/top_n/index.tsx # x-pack/plugins/security_solution/public/common/containers/global_time/index.tsx # x-pack/plugins/security_solution/public/hosts/pages/details/index.tsx # x-pack/plugins/security_solution/public/hosts/pages/details/types.ts # x-pack/plugins/security_solution/public/hosts/pages/hosts.tsx # x-pack/plugins/security_solution/public/hosts/pages/index.tsx # x-pack/plugins/security_solution/public/network/components/embeddables/embedded_map.tsx # x-pack/plugins/security_solution/public/network/components/embeddables/types.ts # x-pack/plugins/security_solution/public/network/pages/index.tsx # x-pack/plugins/security_solution/public/network/pages/network.tsx # x-pack/plugins/security_solution/public/overview/components/alerts_by_category/index.tsx # x-pack/plugins/security_solution/public/overview/components/overview_host/index.tsx # x-pack/plugins/security_solution/public/overview/components/overview_network/index.tsx # x-pack/plugins/security_solution/public/overview/pages/overview.tsx
…y-use-global-time-hook
|
Pinging @elastic/siem (Team:SIEM) |
|
@elasticmachine merge upstream |
cnasikas
reviewed
Jun 30, 2020
x-pack/plugins/security_solution/public/common/containers/use_global_time/index.tsx
Outdated
Show resolved
Hide resolved
cnasikas
reviewed
Jun 30, 2020
x-pack/plugins/security_solution/public/hosts/pages/hosts.test.tsx
Outdated
Show resolved
Hide resolved
…y-use-global-time-hook
…y-use-global-time-hook # Conflicts: # x-pack/plugins/security_solution/public/alerts/components/alerts_histogram_panel/index.tsx # x-pack/plugins/security_solution/public/network/components/embeddables/types.ts # x-pack/plugins/security_solution/public/overview/pages/overview.tsx
|
@elasticmachine merge upstream |
…y-use-global-time-hook
…y-use-global-time-hook # Conflicts: # x-pack/plugins/security_solution/public/common/components/top_n/index.tsx # x-pack/plugins/security_solution/public/common/components/top_n/top_n.tsx # x-pack/plugins/security_solution/public/overview/components/events_by_dataset/index.tsx # x-pack/plugins/security_solution/public/overview/components/signals_by_category/index.tsx
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Jul 6, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 6, 2020
* master: [APM] Fix flaky e2e’s (elastic#70790) [Discover] Migrate server side saved object from data to discover plugin (elastic#70342) [APM] Update docs on running API tests (elastic#70765) test: 💍 delete a flaky test (elastic#70785) [Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… (elastic#69345) Remove IE11 mention from PR template [skip ci] (elastic#70486) [GS] add savedObjects result provider (elastic#68619) remove snapshot from disabled test suite. (elastic#70769)
patrykkopycinski
added a commit
that referenced
this pull request
Jul 6, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 7, 2020
* actions/feature: improved copy [APM] Fix flaky e2e’s (elastic#70790) [Discover] Migrate server side saved object from data to discover plugin (elastic#70342) [APM] Update docs on running API tests (elastic#70765) test: 💍 delete a flaky test (elastic#70785) [Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… (elastic#69345) Remove IE11 mention from PR template [skip ci] (elastic#70486) [GS] add savedObjects result provider (elastic#68619) remove snapshot from disabled test suite. (elastic#70769)
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…anup types
Summary
Cleanup render props approach with hooks 🚀
Checklist