Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing sum in histogram if mode is set to total #702

Closed
wants to merge 8 commits into from

Conversation

bobrik
Copy link

@bobrik bobrik commented Nov 15, 2013

In "total" mode:

total

other modes look as before:

other

Very convenient if you use "total". Turns out that people don't like to calculate sums themselves.

@olej-a
Copy link

olej-a commented Nov 15, 2013

@bobrik
Copy link
Author

bobrik commented Nov 15, 2013

@olej-a like this? :)

sum

@olej-a
Copy link

olej-a commented Nov 15, 2013

exactly

@bobrik
Copy link
Author

bobrik commented Nov 15, 2013

@olej-a, Σ is smaller, but looks cool, I updated request.

sigma

@olej-a
Copy link

olej-a commented Nov 15, 2013

sigma ok, may be missing "hits" word in parentheses

@bobrik
Copy link
Author

bobrik commented Nov 15, 2013

@olej-a makes sense, updated

@mithun35h
Copy link

Great Update, Thanks 👍

@bobrik
Copy link
Author

bobrik commented Dec 14, 2013

@rashidkpc any feedback?

@rashidkpc
Copy link
Contributor

Looks good, though maybe it would be better to not even show the count? Showing the count and the total makes the legend values really long.

@bobrik
Copy link
Author

bobrik commented Dec 19, 2013

Count helps to understand diversity of data. If one query gives 10 hits and sum is 100 000, and other query gives 1000 hits and sum is 1000, that could help to understand data.

@bobrik
Copy link
Author

bobrik commented Dec 19, 2013

Like this:

example

@bobrik
Copy link
Author

bobrik commented Jan 5, 2014

I fixed this with the latest master, it should work as before.

@mcuadros
Copy link

mcuadros commented Jan 8, 2014

+1

@bobrik
Copy link
Author

bobrik commented Feb 18, 2014

Conflicts fixed it anyone cares.

@w33ble w33ble closed this Oct 6, 2014
@spalger
Copy link
Contributor

spalger commented Oct 6, 2014

Woops! Sorry about that! We recently replaced the master branch with Kibana 4. This action force closed all of the old pull requests against master. We will be reviewing these on a case-by-case basis and creating new tickets as necessary.

The good news is that many long requested features can be found in Kibana 4, and we're being entirely open about our roadmap. Check out the roadmap tickets (which we're still filling in) here.

If you're looking for the old Kibana 3 code you can find it here.

w33ble pushed a commit to w33ble/kibana that referenced this pull request Sep 13, 2018
* Added EUI to color picker

* Cleaned up styles

* Fixed label margin in series style simple template

* Added style to hackery.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants