Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard First] Lens By Value #70272

Closed
wants to merge 70 commits into from
Closed

[Dashboard First] Lens By Value #70272

wants to merge 70 commits into from

Commits on Jun 25, 2020

  1. Made lens work with the attribute service copied from elastic#68719

    @ThomThomson
    ThomThomson committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    297dba0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    168825a View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Editing lens by value now works.

    @ThomThomson
    ThomThomson committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    0039a97 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    8ec8020 View commit details
    Browse the repository at this point in the history

  3. Allow by value lens embeddable to be made by reference via the save a… 

    …s button
    @ThomThomson
    ThomThomson committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    681625f View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    473a052 View commit details
    Browse the repository at this point in the history

  2. fixed up some jest tests

    @ThomThomson
    ThomThomson committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    3ee8263 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. functional and jest test fixes

    @ThomThomson
    ThomThomson committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    a34d585 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    b7ff957 View commit details
    Browse the repository at this point in the history

  3. fix for visualize by value

    @ThomThomson
    ThomThomson committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    5d05ac9 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    adc1298 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    a3d0adc View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Restructured adding and editing to minimize deletion of embeddables a… 

    …nd re-rendering
    @ThomThomson
    ThomThomson committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    3ecb3d9 View commit details
    Browse the repository at this point in the history

  2. eslint changes

    @ThomThomson
    ThomThomson committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    72a068a View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. cleanup continued...

    @ThomThomson
    ThomThomson committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    d1ab683 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    9cb9a7c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. Finished cleanup - separated embeddableId and savedObjectId in lens t… 

    …o avoid confusion. Added cancel button
    @ThomThomson
    ThomThomson committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    a0fffd0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    4d64d5e View commit details
    Browse the repository at this point in the history

  3. Test fixes

    @ThomThomson
    ThomThomson committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    9e5f7a9 View commit details
    Browse the repository at this point in the history

  4. More test fixes, started on feature flag creation

    @ThomThomson
    ThomThomson committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    580fbba View commit details
    Browse the repository at this point in the history

  5. Finished feature flag

    @ThomThomson
    ThomThomson committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    df5fad0 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    c6d87c7 View commit details
    Browse the repository at this point in the history

  2. Updated jest test - because the newly created prop is now set correctly.

    @ThomThomson
    ThomThomson committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    cd61dfc View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. remove byValueMode from editorState in favor of using the embeddableI… 

    …d to determine if newly created or editing
    @ThomThomson
    ThomThomson committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    7f86d23 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    43657f9 View commit details
    Browse the repository at this point in the history

  3. rename edit mode for clarity. Update ternary

    @ThomThomson
    ThomThomson committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    888ca49 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Type fixes

    @ThomThomson
    ThomThomson committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    b9d9c5c View commit details
    Browse the repository at this point in the history

  2. Jest fix

    @ThomThomson
    ThomThomson committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    c823217 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    87a780c View commit details
    Browse the repository at this point in the history

  4. merge fix

    @ThomThomson
    ThomThomson committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    d3d2cfd View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Merge branch 'master' into feature/lensByValue

    @elasticmachine
    elasticmachine authored Jul 27, 2020
    Configuration menu
    Copy the full SHA
    b793ca3 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    ef65220 View commit details
    Browse the repository at this point in the history

  2. merge fix

    @ThomThomson
    ThomThomson committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    ee625ec View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    4e39564 View commit details
    Browse the repository at this point in the history

  2. cleaned up visualize state transfer package, set new lens flow defaul… 

    …t to false
    @ThomThomson
    ThomThomson committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    ed461d3 View commit details
    Browse the repository at this point in the history

  3. cleaned up visualize state transfer package, set new lens flow defaul… 

    …t to false
    @ThomThomson
    ThomThomson committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    c9878c5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/lensByValue' of github.com:ThomThomson/kibana i… 

    …nto feature/lensByValue
    @ThomThomson
    ThomThomson committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    cb72a3e View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Added an interface for all by value or by reference embeddables to in… 

    …herit from. This will be used for the add to library and unlink from library actions. Cached the attribute service
    @ThomThomson
    ThomThomson committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    a5910f2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    ac5c91a View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    068ebaf View commit details
    Browse the repository at this point in the history

  2. Removed lens by value config in favor of the dashboard-wide config from 

    elastic#73870
    @ThomThomson
    ThomThomson committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    c1435e0 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. removed unused config related code from lens

    @ThomThomson
    ThomThomson committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    ac94aec View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    642eea8 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    9af2c06 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    8b43747 View commit details
    Browse the repository at this point in the history

  2. Merge continued...

    @ThomThomson
    ThomThomson committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    df876af View commit details
    Browse the repository at this point in the history

  3. Merge continued...

    @ThomThomson
    ThomThomson committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    aeb25ee View commit details
    Browse the repository at this point in the history

  4. Maps Update

    @ThomThomson
    ThomThomson committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    6fc1f00 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    9598011 View commit details
    Browse the repository at this point in the history

  2. Finished merge with visualize editor

    @ThomThomson
    ThomThomson committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    10d98e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Merge branch 'master' into feature/lensByValue

    @elasticmachine
    elasticmachine authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    e85caeb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/lensByValue' of github.com:ThomThomson/kibana i… 

    …nto feature/lensByValue
    @ThomThomson
    ThomThomson committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    2ef26c6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    ff13e40 View commit details
    Browse the repository at this point in the history

  4. Added custom save method to attribute service to allow lens specific … 

    …saving.
    @ThomThomson
    ThomThomson committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    3411c36 View commit details
    Browse the repository at this point in the history

  5. Small fix for lens embeddables on canvas, made cancel button show up … 

    …regardless of by value mode.
    @ThomThomson
    ThomThomson committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    1d5b123 View commit details
    Browse the repository at this point in the history

  6. Test fix

    @ThomThomson
    ThomThomson committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    f497244 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Removed accidental duplication of ref_or_val_embeddable. Added tests … 

    …for lens menu items
    @ThomThomson
    ThomThomson committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    5b6d397 View commit details
    Browse the repository at this point in the history

  2. M o n s t e r M e r g e branch 'master' of github.com:elastic/kibana … 

    …into feature/lensByValue
    @ThomThomson
    ThomThomson committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    d345571 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2020

  1. Made attribute service unwrap references as well

    @ThomThomson
    ThomThomson committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    0dee8a7 View commit details
    Browse the repository at this point in the history

  2. type and jest fix

    @ThomThomson
    ThomThomson committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    12b9aa4 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    e3dc91a View commit details
    Browse the repository at this point in the history

  2. Simplified and separated redirectTo method, made dashboard merge inco… 

    …ming input to preserve custom panel titles
    @ThomThomson
    ThomThomson committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    29ae393 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    719d67c View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    3470c63 View commit details
    Browse the repository at this point in the history

  2. changed feature flag config to match dashboard

    @ThomThomson
    ThomThomson committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    566500c View commit details
    Browse the repository at this point in the history

  3. cleaned up types after 75560

    @ThomThomson
    ThomThomson committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    8796ab0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    216fd7f View commit details
    Browse the repository at this point in the history

  5. Type cleanup continued

    @ThomThomson
    ThomThomson committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    d0e3fd8 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into feature/lensB… 

    …yValue
    @ThomThomson
    ThomThomson committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    6f28a7f View commit details
    Browse the repository at this point in the history

  2. update eslint

    @ThomThomson
    ThomThomson committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    cf74955 View commit details
    Browse the repository at this point in the history