Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adding peak_model_bytes to model size stats type #70825

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jul 6, 2020

Closes #70717, to handle the new model size stat peak_model_bytes. This is added to the 'Model size stats' panel displayed in the 'Counts' tab of the expanded row in the Anomaly detection job management page, to give the user information about the peak memory usage of the model.

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 6, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 6, 2020 15:41
@jgowdyelastic jgowdyelastic self-assigned this Jul 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson added release_note:enhancement and removed non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes labels Jul 6, 2020
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit f18002c into elastic:master Jul 7, 2020
@jgowdyelastic jgowdyelastic deleted the adding-peak_model_bytes-to-model-size-stats-type branch July 7, 2020 08:24
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jul 7, 2020
* [ML] Adding peak_model_bytes to model size stats type

* adding formatter
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
* master:
  [ML] Adding peak_model_bytes to model size stats type (elastic#70825)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
…rbac

* alerting/consumer-based-rbac:
  Rename legacy ES mock accessors (elastic#70432)
  [APM] Adds 'Anomaly detection' settings page to create ML jobs per environment (elastic#70560)
  Forbid timezones not working in Elasticsearch (elastic#70780)
  [ML] Adding peak_model_bytes to model size stats type (elastic#70825)
jgowdyelastic added a commit that referenced this pull request Jul 8, 2020
* [ML] Adding peak_model_bytes to model size stats type

* adding formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Add model_size_stats.peak_model_bytes to schema and formatting
5 participants