Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] fix fit to data for Point to Point layer #73563

Merged
merged 3 commits into from
Jul 29, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 28, 2020

Fixes #72742

Adds getBoundsForFilters implementation to ESPewPewSource that returns the bounding box for destination and source fields.

@nreese nreese requested a review from nickpeihl July 28, 2020 22:20
@nreese nreese requested a review from a team as a code owner July 28, 2020 22:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Jul 28, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
maps 3.8MB +1.4KB 3.8MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! code review and tested in chrome

@nreese nreese merged commit 2f93a6e into elastic:master Jul 29, 2020
nreese added a commit to nreese/kibana that referenced this pull request Jul 29, 2020
* [Maps] fix fit to data for Point to Point layer

* tslint

Co-authored-by: Elastic Machine <[email protected]>
nreese added a commit that referenced this pull request Jul 29, 2020
* [Maps] fix fit to data for Point to Point layer

* tslint

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
nreese added a commit that referenced this pull request Jul 29, 2020
* merge conflicts

* tslint cleanup

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
…ibana into actions/webhook-remove-header

* 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
  [Maps] fix fit to data for Point to Point layer (elastic#73563)
  [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Fit to Data not working in Point to Point layer
4 participants