Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we might need to wait for popup to disappear
return (await testSubjects.exists('confirmSaveSavedObjectButton', { timeout: 5000 })) === false
Is there a chance that popup will remain in place and
header.isGlobalLoadingIndicatorVisible()
will returntrue
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point 👍 , I will take a closer look here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we can always catch the loading indicator after clicking save. Could it be that in some cases the save is quick enough that we never see the loading indicator?
Also, if we do find the loading indicator, I think we should then wait for it to be hidden before returning from saveSearch method. I think waitUntilLoadingHasFinished was doing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the code to check for the save button not to be disabled, this should catch the occasional
flakiness when for whatever reason the title wasn't entered, and the save button stayed disabled therefore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flaky test runner says, it's ok this way: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/712/