[Security Solution] Keep original note creator #74203

angorayc · 2020-08-03T23:59:59Z

Summary

The notes creator of imported timelines / templates should be remained instead of being override by current user.

Before the fix, it overrides the original note creator

solution:
Introducing a flag overideNote :
allow override means overriding by current username,
disallow override means keep the original username.
disallow override only happens when import timeline templates, as we want to keep the original creator for notes

How to verify this PR:

Download templates_with_note.txt
change the extension from .txt into .ndjson
import it and expend the note for the timeline you just imported from timeline's table
the original author should be displayed

Checklist

Delete any items that are not applicable to this PR.

~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~
~~This renders correctly on smaller devices using a responsive layout. (You can test this in your browser~~
~~This was checked for cross-browser compatibility~~

For maintainers

~~This was checked for breaking API changes and was labeled appropriately~~

elasticmachine · 2020-08-04T00:00:01Z

Pinging @elastic/siem (Team:SIEM)

stephmilovic · 2020-08-04T14:30:58Z

is duplicating the timeline supposed to include the notes?

stephmilovic · 2020-08-04T14:46:41Z

idk if its just me, but i cant scroll in the notes view down to see the note?

angorayc · 2020-08-04T15:00:50Z

is duplicating the timeline supposed to include the notes?

No, duplicating the timeline does not duplicate the notes.

angorayc · 2020-08-04T15:08:22Z

idk if its just me, but i cant scroll in the notes view down to see the note?

@stephmilovic I found that I have to have my cursor on the notes to trigger scrolling, if my mouse is outside of notes content, I cannot scroll.

stephmilovic

code looks good. tested locally and it works as expected now. thanks, LGTM!

angorayc · 2020-08-04T15:36:34Z

@stephmilovic , would this be better or it looks weird ? or we could probably fix the pannel's header?

stephmilovic · 2020-08-04T15:38:52Z

@stephmilovic , would this be better or it looks weird ? or we could probably fix the pannel's header?

yes i like this better, thanks @angorayc !!

x-pack/plugins/security_solution/server/lib/timeline/routes/utils/create_timelines.ts

x-pack/plugins/security_solution/server/lib/note/saved_object.ts

kibanamachine · 2020-08-04T18:47:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b42aa89

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	-313.0B	7.3MB

page load bundle size

id	value	diff	baseline
securitySolution	869.9KB	-190.0B	870.1KB

History

💚 Build #66404 succeeded b0cd98f
💔 Build #66356 failed e03918d
💚 Build #66280 succeeded 86bf9e4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* keep original note creator * unit test * fix types * typo * wording

* keep original note creator * unit test * fix types * typo * wording Co-authored-by: Angela Chuang <[email protected]>

* master: (74 commits) [Discover] Inline noWhiteSpace function (elastic#74331) [DOCS] Add Observability topic (elastic#73041) skip flaky suite (elastic#74327) [Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (elastic#74317) [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (elastic#74250) Fixed Alert details does not update page title and breadcrumb (elastic#74214) [src/dev/build] build Kibana Platform bundles from source (elastic#73591) [Reporting] Shorten asset path to help CLI FS Watcher (elastic#74185) Fix TMS not loaded in legacy maps (elastic#73570) [Security Solution] styling for notes' panel (elastic#74274) [Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (elastic#74268) Make the actions plugin support generics (elastic#71439) [Security Solution] Keep original note creator (elastic#74203) [CI] Fix xpack kibana build dir in xpack visual regression script [CI] Fix baseline_capture job by adding parallel process number back [Monitoring] Ensure setup mode works on cloud but only for alerts (elastic#73127) [Maps] Custom color ramps should show correctly on the map for mvt layers (elastic#74169) [kbn/optimizer] remove unused modules (elastic#74195) [CI] Add pipeline task queue framework and merge workers into one (elastic#71268) Using msearch for tree api endpoint (elastic#73813) ...

* master: (115 commits) [Logs UI] Correct trial period duration in anomaly splash screen (elastic#74249) [Discover] Inline noWhiteSpace function (elastic#74331) [DOCS] Add Observability topic (elastic#73041) skip flaky suite (elastic#74327) [Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (elastic#74317) [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (elastic#74250) Fixed Alert details does not update page title and breadcrumb (elastic#74214) [src/dev/build] build Kibana Platform bundles from source (elastic#73591) [Reporting] Shorten asset path to help CLI FS Watcher (elastic#74185) Fix TMS not loaded in legacy maps (elastic#73570) [Security Solution] styling for notes' panel (elastic#74274) [Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (elastic#74268) Make the actions plugin support generics (elastic#71439) [Security Solution] Keep original note creator (elastic#74203) [CI] Fix xpack kibana build dir in xpack visual regression script [CI] Fix baseline_capture job by adding parallel process number back [Monitoring] Ensure setup mode works on cloud but only for alerts (elastic#73127) [Maps] Custom color ramps should show correctly on the map for mvt layers (elastic#74169) [kbn/optimizer] remove unused modules (elastic#74195) [CI] Add pipeline task queue framework and merge workers into one (elastic#71268) ...

* master: (154 commits) [ML] Fix initial plugin's bundle size (elastic#74047) [Ingest Manager] prevent crash on unhandled rejection from setupIngestManager (elastic#74300) [Logs UI] Correct trial period duration in anomaly splash screen (elastic#74249) [Discover] Inline noWhiteSpace function (elastic#74331) [DOCS] Add Observability topic (elastic#73041) skip flaky suite (elastic#74327) [Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (elastic#74317) [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (elastic#74250) Fixed Alert details does not update page title and breadcrumb (elastic#74214) [src/dev/build] build Kibana Platform bundles from source (elastic#73591) [Reporting] Shorten asset path to help CLI FS Watcher (elastic#74185) Fix TMS not loaded in legacy maps (elastic#73570) [Security Solution] styling for notes' panel (elastic#74274) [Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (elastic#74268) Make the actions plugin support generics (elastic#71439) [Security Solution] Keep original note creator (elastic#74203) [CI] Fix xpack kibana build dir in xpack visual regression script [CI] Fix baseline_capture job by adding parallel process number back [Monitoring] Ensure setup mode works on cloud but only for alerts (elastic#73127) [Maps] Custom color ramps should show correctly on the map for mvt layers (elastic#74169) ...

elasticmachine · 2021-09-23T14:27:33Z

Pinging @elastic/security-solution (Team: SecuritySolution)

keep original note creator

86bf9e4

angorayc added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Aug 3, 2020

angorayc requested review from a team as code owners August 3, 2020 23:59

unit test

e03918d

fix types

b0cd98f

stephmilovic approved these changes Aug 4, 2020

View reviewed changes

patrykkopycinski reviewed Aug 4, 2020

View reviewed changes

x-pack/plugins/security_solution/server/lib/timeline/routes/utils/create_timelines.ts Outdated Show resolved Hide resolved

x-pack/plugins/security_solution/server/lib/note/saved_object.ts Outdated Show resolved Hide resolved

angorayc mentioned this pull request Aug 4, 2020

[Security Solution] styling for notes' panel #74274

Merged

angorayc added 2 commits August 4, 2020 17:55

typo

482c70c

wording

b42aa89

patrykkopycinski approved these changes Aug 4, 2020

View reviewed changes

XavierM merged commit 8e0e228 into elastic:master Aug 4, 2020

XavierM pushed a commit to XavierM/kibana that referenced this pull request Aug 4, 2020

[Security Solution] Keep original note creator (elastic#74203)

84a1610

* keep original note creator * unit test * fix types * typo * wording

XavierM mentioned this pull request Aug 4, 2020

[7.x] [Security Solution] Keep original note creator (#74203) #74293

Merged

XavierM pushed a commit to XavierM/kibana that referenced this pull request Aug 4, 2020

[Security Solution] Keep original note creator (elastic#74203)

955be86

* keep original note creator * unit test * fix types * typo * wording

XavierM mentioned this pull request Aug 4, 2020

[7.9] [Security Solution] Keep original note creator (#74203) #74295

Merged

angorayc added a commit that referenced this pull request Aug 4, 2020

[Security Solution] Keep original note creator (#74203) (#74293)

8ca6677

* keep original note creator * unit test * fix types * typo * wording Co-authored-by: Angela Chuang <[email protected]>

angorayc added a commit that referenced this pull request Aug 4, 2020

[Security Solution] Keep original note creator (#74203) (#74295)

79359ff

* keep original note creator * unit test * fix types * typo * wording Co-authored-by: Angela Chuang <[email protected]>

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Keep original note creator #74203

[Security Solution] Keep original note creator #74203

angorayc commented Aug 3, 2020 •

edited

Loading

elasticmachine commented Aug 4, 2020

stephmilovic commented Aug 4, 2020

stephmilovic commented Aug 4, 2020

angorayc commented Aug 4, 2020

angorayc commented Aug 4, 2020

stephmilovic left a comment

angorayc commented Aug 4, 2020

stephmilovic commented Aug 4, 2020

kibanamachine commented Aug 4, 2020

elasticmachine commented Sep 23, 2021

[Security Solution] Keep original note creator #74203

[Security Solution] Keep original note creator #74203

Conversation

angorayc commented Aug 3, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Aug 4, 2020

stephmilovic commented Aug 4, 2020

stephmilovic commented Aug 4, 2020

angorayc commented Aug 4, 2020

angorayc commented Aug 4, 2020

stephmilovic left a comment

Choose a reason for hiding this comment

angorayc commented Aug 4, 2020

stephmilovic commented Aug 4, 2020

kibanamachine commented Aug 4, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

elasticmachine commented Sep 23, 2021

angorayc commented Aug 3, 2020 •

edited

Loading