-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hides advanced json for count metric #74636
Merged
stratoula
merged 14 commits into
elastic:master
from
stratoula:count-agg-remove-advanced-json
Aug 31, 2020
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6a32f32
remove advanced json for count agg
stratoula 3bb8102
Remove only advanced json from count agg
stratoula e6e12f1
Merge branch 'master' into count-agg-remove-advanced-json
elasticmachine 370d624
Merge branch 'master' into count-agg-remove-advanced-json
elasticmachine 2e92418
Merge branch 'master' into count-agg-remove-advanced-json
elasticmachine dc495c3
Merge branch 'master' into count-agg-remove-advanced-json
elasticmachine 49c4bb3
use Constant from data plugin
stratoula bf0f6fa
add the logic to data plugin
stratoula d3a52a9
remove json arg from function definition
stratoula 4424f0d
Merge branch 'master' into count-agg-remove-advanced-json
stratoula 54ac39e
remove unecessary translations
stratoula 73747e3
Merge branch 'master' into count-agg-remove-advanced-json
elasticmachine 31bfadc
Merge branch 'master' into count-agg-remove-advanced-json
elasticmachine 250e208
Merge branch 'master' into count-agg-remove-advanced-json
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the
json
argument from the function definition above as well, since it's no longer being used.Note that this might cause a TS error because the function definition is using
AggExpressionFunctionArgs
which is pulling the relevant type from theAggParamsMapping
. Forcount
, the value used isBaseAggParams
which includes json:kibana/src/plugins/data/common/search/aggs/types.ts
Line 138 in bf0f6fa
If TS gives you trouble, you may need to define an
AggParamsMetricCount
in thecount.ts
file without extendingBaseAggParams
as others agg types do.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx @lukeelmers , I missed that, TS looks happy btw :)