GS providers improvements #75174
GS providers improvements #75174
Conversation
pgayvallet
added
release_note:skip
|
Pinging @elastic/kibana-core-ui (Team:Core UI) |
|
Pinging @elastic/kibana-platform (Team:Platform) |
| const navLinkStatus = | ||
| app.navLinkStatus === AppNavLinkStatus.default | ||
| ? app.status === AppStatus.inaccessible | ||
| ? AppNavLinkStatus.hidden | ||
| : AppNavLinkStatus.visible | ||
| : app.navLinkStatus!; | ||
| if (isLegacyApp(app)) { |
There was a problem hiding this comment.
getAppInfo now computes the navlink status as it was more or less done in
kibana/src/core/public/chrome/nav_links/to_nav_link.ts
Lines 38 to 41 in 0247df4
As AppServiceStart.applications$ is a public API that is supposed to return the computed state of the apps, I think it make sense, instead of letting the consumers manually apply this logic.
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
| @@ -25,7 +25,7 @@ export const createSavedObjectsResultProvider = (): GlobalSearchResultProvider = | |||
| const responsePromise = client.find({ | |||
| page: 1, | |||
| perPage: maxResults, | |||
| search: term, | |||
| search: term ? `${term}*` : undefined, | |||
There was a problem hiding this comment.
Is there any issue with using *${term}* so we can match anywhere in the field? Maybe this reduces the quality of the search results.
Ideally, we'd be boosting results where the beginning of the field matches the search term, probably using multiple should clauses, one with the phrase_prefix match type. Definitely out of scope here though.
There was a problem hiding this comment.
Is there any issue with using ${term} so we can match anywhere in the field? Maybe this reduces the quality of the search results.
Yea, I'm not really sure. Without proper boost, searching anywhere in the field can have some unexpected behavior in term of results. I feel like until we are able to construct a more precise search dsl, prefix-only may be better.
@ryankeairns WDYT?
There was a problem hiding this comment.
I’m happy with the prefix-only change for now and collecting more feedback post-merge/release.
* exclude apps with non visible navlinks from results * change SO provider to prefix search * fix service tests
|
Thanks for the quick work on this! |
* master: Skip failing test in CI (elastic#75266) [Task Manager] time out work when it overruns in poller (elastic#74980) [Drilldowns] misc improvements & fixes (elastic#75276) Small README note on bumping memory for builds (elastic#75247) [Security Solution][Detections] Adds exception modal tests (elastic#74596) [Dashboard] Sample data link does not work (elastic#75262) [Dashboard First] Unlink from Library Action With ReferenceOrValueEmbeddable (elastic#74905) [Form lib] Fix issue where serializer on fields are called on every change (elastic#75166) convert processor labels to sentence case (elastic#75278) [Monaco] Refactor the way XJSON grammar checker gets registered (elastic#75160) Clarify no documents error message when filtering by is_training (elastic#75227) [Lens] Fix crash when two layers xychart switches to pie (elastic#75267) [Observability Homepage] Fix console error because of side effect (elastic#75258) [Usage Collection] Add `legacy=true` option to the /api/stats request in the docs (elastic#75146) [ML] Functional tests - re-activate DFA test suites (elastic#75257) GS providers improvements (elastic#75174) [Visualize] First version of by-value visualize editor (elastic#72256)
…emove-header * saved-objects/version-on-create: (59 commits) remove version when loading sample data omit version from SO import/export Skip failing test in CI (elastic#75266) [Task Manager] time out work when it overruns in poller (elastic#74980) [Drilldowns] misc improvements & fixes (elastic#75276) Small README note on bumping memory for builds (elastic#75247) [Security Solution][Detections] Adds exception modal tests (elastic#74596) Revert "Revert "added missing core docs"" Revert "Revert "added version to saved object bulk creation"" [Dashboard] Sample data link does not work (elastic#75262) [Dashboard First] Unlink from Library Action With ReferenceOrValueEmbeddable (elastic#74905) [Form lib] Fix issue where serializer on fields are called on every change (elastic#75166) convert processor labels to sentence case (elastic#75278) [Monaco] Refactor the way XJSON grammar checker gets registered (elastic#75160) Clarify no documents error message when filtering by is_training (elastic#75227) [Lens] Fix crash when two layers xychart switches to pie (elastic#75267) [Observability Homepage] Fix console error because of side effect (elastic#75258) [Usage Collection] Add `legacy=true` option to the /api/stats request in the docs (elastic#75146) [ML] Functional tests - re-activate DFA test suites (elastic#75257) GS providers improvements (elastic#75174) ...
Summary
Fix #75050
Checklist