Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Visualize] First version of by-value visualize editor (#72256) #75270

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

majagrubic
Copy link
Contributor

Backports the following commits to 7.x:

* First version of new by-value editor

Fixing broken behavior and applying relevant changes

Adding changes to dashboard

Removing unnecessary empty line

Removing unnecessary deepClone

Fixing some stuff in dashboard container

Extracting logic into common components

Fixing eslint

Fix breadcrumbs

Fixing error in search interceptor

Reintroduce mistakenly removed empty lines

Renaming function

* Adding missing null check

* Making typescript play nicely

* Fixing failing tests

* Applying PR comments

* Fixing eslint errors

* Fix save as behavior

* Fixing HTMLElement type

* Passing in setOriginatingApp parameter

* Redirect back to dashboard if input is missing

* Fixing i18n error

* Unlink saved search

* Fix duplicating embeddable by reference

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
visualize 311 +3 308

async chunks size

id value diff baseline
visualize 693.8KB +16.4KB 677.4KB

page load bundle size

id value diff baseline
dashboard 687.9KB +169.0B 687.7KB
embeddable 360.4KB +179.0B 360.2KB
navigation 164.7KB +26.0B 164.7KB
visualizations 408.9KB +15.0B 408.9KB
visualize 31.0KB +36.0B 30.9KB
total +425.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@majagrubic majagrubic merged commit 09a2db8 into elastic:7.x Aug 18, 2020
@majagrubic majagrubic deleted the backport/7.x/pr-72256 branch August 18, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants