Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form lib] Correctly add field to form on component mount #75796

Merged
merged 22 commits into from
Aug 27, 2020
Merged

[Form lib] Correctly add field to form on component mount #75796

merged 22 commits into from
Aug 27, 2020

Commits on Aug 24, 2020

  1. Refactor use_field and use_form to correctly add field

    @sebelga
    sebelga committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    b852854 View commit details
    Browse the repository at this point in the history

  2. [Security solution] Update RuleActionsField comp to not rely on the f… 

    …orm object from field

I removed the form object form the field object to avoid unnecessary effect triggers. The form object should be accessed by context with the "useFormContext()" hook.
    @sebelga
    sebelga committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    18adb6d View commit details
    Browse the repository at this point in the history

  3. Fix pipeline processors

    @sebelga
    sebelga committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    e378a2f View commit details
    Browse the repository at this point in the history

  4. Update mappings editor to use memoize config and validation for fields

    @sebelga
    sebelga committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    31d9e3b View commit details
    Browse the repository at this point in the history

  5. Fix component integration tests

    @sebelga
    sebelga committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    4f80819 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. Fix TS issue

    @sebelga
    sebelga committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    abbda2c View commit details
    Browse the repository at this point in the history

  2. [Form lib] FromDataProvider don't render anything until fields have m… 

    …ounted
    @sebelga
    sebelga committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    5afe601 View commit details
    Browse the repository at this point in the history

  3. [Security solution] Fix riskScore form fields

    @sebelga
    sebelga committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    73c86a7 View commit details
    Browse the repository at this point in the history

  4. [Security solution] Fix security level form fields

    @sebelga
    sebelga committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    bca378b View commit details
    Browse the repository at this point in the history

  5. [Form lib] Update form defaultValue whenever prop changes

    @sebelga
    sebelga committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    d0f02db View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into bug/form-lib-addf… 

    …ield-on-component-mount
    @sebelga
    sebelga committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    4f8e5a7 View commit details
    Browse the repository at this point in the history

  7. Fix i18n issue

    @sebelga
    sebelga committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    9ccde27 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into bug/form-lib-addfield-on-component-mount

    @elasticmachine
    elasticmachine authored Aug 25, 2020
    Configuration menu
    Copy the full SHA
    e3d5594 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Fix jest test

    @sebelga
    sebelga committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    fb8de5c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bug/form-lib-addfield-on-component-mount' of github.com… 

    …:sebelga/kibana into bug/form-lib-addfield-on-component-mount
    @sebelga
    sebelga committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    55593c1 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into bug/form-lib-addf… 

    …ield-on-component-mount
    @sebelga
    sebelga committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    d04098b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into bug/form-lib-addfield-on-component-mount

    @elasticmachine
    elasticmachine authored Aug 26, 2020
    Configuration menu
    Copy the full SHA
    ef8aa16 View commit details
    Browse the repository at this point in the history

  5. RiskScore: don't convert empty string to number

    @sebelga
    sebelga committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    bd693da View commit details
    Browse the repository at this point in the history

  6. Merge branch 'bug/form-lib-addfield-on-component-mount' of github.com… 

    …:sebelga/kibana into bug/form-lib-addfield-on-component-mount
    @sebelga
    sebelga committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    20e723d View commit details
    Browse the repository at this point in the history

  7. Put back "severity" and "riskScore" in the form schema 

    The way the information about a rule is shown depends on keys defined on the form schema. This is a potential future bug as there is only 1 field declared in the JSX (e.g. "riskScore") so what is inside the object is expected to be FieldConfig properties.
    @sebelga
    sebelga committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    c529e80 View commit details
    Browse the repository at this point in the history

  8. Add test coverage to FormDataProvider to subscribe to updated form value

    @sebelga
    sebelga committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    44b5572 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Merge branch 'master' into bug/form-lib-addfield-on-component-mount

    @elasticmachine
    elasticmachine authored Aug 27, 2020
    Configuration menu
    Copy the full SHA
    b0c271f View commit details
    Browse the repository at this point in the history