Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use observer.hostname instead of observer.name #76074

Merged
merged 6 commits into from
Sep 7, 2020
Merged

[APM] Use observer.hostname instead of observer.name #76074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eceb500
[APM] Use observer.hostname instead of observer.name
dgieselaar Aug 27, 2020
e8d5483
Run telemetry task immediately if versions are incompatible; add serv…
dgieselaar Aug 27, 2020
daff420
Merge branch 'master' of github.com:elastic/kibana into observer-host…
dgieselaar Sep 2, 2020
1c5e9e3
Correct structure for environment properties
dgieselaar Sep 2, 2020
2938c5a
Merge branch 'master' of github.com:elastic/kibana into observer-host…
dgieselaar Sep 4, 2020
f1898c8
Merge branch 'master' of github.com:elastic/kibana into observer-host…
dgieselaar Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 30 additions & 26 deletions x-pack/plugins/apm/common/__snapshots__/apm_telemetry.test.ts.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions x-pack/plugins/apm/common/__snapshots__/elasticsearch_fieldnames.test.ts.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 10 additions & 4 deletions x-pack/plugins/apm/common/apm_telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export function getApmTelemetryMapping() {
properties: {
expected_metric_document_count: long,
transaction_count: long,
ratio: long,
},
};

Expand All @@ -102,10 +103,14 @@ export function getApmTelemetryMapping() {
properties: {
current_implementation: aggregatedTransactionsProperties,
no_observer_name: aggregatedTransactionsProperties,
no_rum: aggregatedTransactionsProperties,
no_rum_no_observer_name: aggregatedTransactionsProperties,
only_rum: aggregatedTransactionsProperties,
only_rum_no_observer_name: aggregatedTransactionsProperties,
with_country: aggregatedTransactionsProperties,
},
},
environments: {
properties: {
services_without_environment: long,
services_with_multiple_environments: long,
top_enviroments: keyword,
},
},
cloud: {
Expand Down Expand Up @@ -227,6 +232,7 @@ export function getApmTelemetryMapping() {
agents: tookProperties,
cardinality: tookProperties,
cloud: tookProperties,
environments: tookProperties,
groupings: tookProperties,
indices_stats: tookProperties,
integrations: tookProperties,
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/common/elasticsearch_fieldnames.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const USER_AGENT_NAME = 'user_agent.name';

export const DESTINATION_ADDRESS = 'destination.address';

export const OBSERVER_NAME = 'observer.name';
export const OBSERVER_HOSTNAME = 'observer.hostname';
export const OBSERVER_VERSION_MAJOR = 'observer.version_major';
export const OBSERVER_LISTENING = 'observer.listening';
export const PROCESSOR_EVENT = 'processor.event';
Expand Down
Loading