Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Refactor Network HTTP to use Search Strategy #76243

Merged
merged 10 commits into from
Sep 2, 2020
Merged

[Security Solution] Refactor Network HTTP to use Search Strategy #76243

merged 10 commits into from
Sep 2, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Aug 29, 2020 •
edited
Loading

Summary

image

Checklist

@patrykkopycinski patrykkopycinski self-assigned this Aug 29, 2020
@patrykkopycinski
cleanup
b2101f5
@patrykkopycinski
SortField
8d59de5
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/networkt…
8bb79d8 
…-tls-search-strategy

# Conflicts:
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/hosts/index.ts
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/index.ts
@patrykkopycinski
Merge branch 'feat/networkt-tls-search-strategy' of github.com:patryk…
e17a88f 
…kopycinski/kibana into feat/networkt-http-search-strategy

# Conflicts:
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/network/index.ts
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/networkt…
78f0897 
…-http-search-strategy

# Conflicts:
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/index.ts
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/network/index.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/index.ts
@patrykkopycinski patrykkopycinski marked this pull request as ready for review August 31, 2020 19:53
@patrykkopycinski patrykkopycinski requested review from a team as code owners August 31, 2020 19:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

angorayc
angorayc reviewed Sep 2, 2020
View reviewed changes
x-pack/plugins/security_solution/public/network/containers/network_http/index.tsx
filterQuery: createFilter(filterQuery),
ip,
pagination: generateTablePaginationOptions(activePage, limit),
sort: sort as SortField,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same issue of SortField too, as some tables do not have any sorting,
what about we make field and direction optional in SortField?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per our conversation, we have decided to refactor that at the end

angorayc
angorayc approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran on my local, looks fine, thank you @patrykkopycinski

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 1939 +1 1938

async chunks size

id value diff baseline
securitySolution 9.8MB +6.2KB 9.8MB

distributable file count

id value diff baseline
total 45537 +4 45533

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit febeb47 into elastic:master Sep 2, 2020
@patrykkopycinski patrykkopycinski deleted the feat/networkt-http-search-strategy branch September 2, 2020 09:30
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 2, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Sep 2, 2020
@patrykkopycinski
[Security Solution] Refactor Network HTTP to use Search Strategy (ela…
bd22306 
…stic#76243)
patrykkopycinski added a commit that referenced this pull request Sep 2, 2020
@patrykkopycinski
[Security Solution] Refactor Network HTTP to use Search Strategy (#76243
4a0fcc9 
) (#76484)
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 24, 2020
Merged
1 task
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @angorayc @MindyRS