Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drilldowns] Config to disable URL Drilldown #77887

Merged
merged 13 commits into from
Sep 23, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 18, 2020

Summary

Part of #69409

This pr makes sure there is way to disable URL drilldown feature.
I decided to extract Url drilldown definition into a separate plugin to benefit from regular disabling a plugin feature.
Having it as a separate plugin also makes sense because we will start adding registries specific to URL drilldown implementation #55324

To disable URL drilldown in kibana.yml:

url_drilldown.enabled: false

It is a valid use case now that URL drilldown is disabled, but there are stored url drilldown actions on a dashboard panel. To handle this better I changed error handling code around dynamic_action_manager to make sure that failing to revive an action wouldn't break all drilldowns on a dashboard.

This what an editor would see in case there is a stored URL drilldown on a dashboard panel, but the plugin is disabled:

Screenshot 2020-09-18 at 13 05 38

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@Dosant Dosant mentioned this pull request Sep 18, 2020
24 tasks
@Dosant Dosant added Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.10.0 v8.0.0 labels Sep 18, 2020
@Dosant Dosant marked this pull request as ready for review September 18, 2020 15:14
@Dosant Dosant requested a review from a team as a code owner September 18, 2020 15:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

…rl-drilldown

# Conflicts:
#	x-pack/plugins/ui_actions_enhanced/public/dynamic_actions/dynamic_action_manager.ts
#	x-pack/plugins/ui_actions_enhanced/public/plugin.ts
@Dosant
Copy link
Contributor Author

Dosant commented Sep 22, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
embeddableEnhanced 11 -5 16
urlDrilldown 8 +8 -
total +3

page load bundle size

id value diff baseline
embeddableEnhanced 25.5KB -14.8KB 40.4KB
uiActions 223.5KB +109.0B 223.4KB
uiActionsEnhanced 380.5KB +420.0B 380.1KB
urlDrilldown 18.7KB +18.7KB -
total +4.4KB

distributable file count

id value diff baseline
default 45946 +4 45942

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 4b6d77f into elastic:master Sep 23, 2020
Dosant added a commit to Dosant/kibana that referenced this pull request Sep 23, 2020
This pr makes sure there is way to disable URL drilldown feature.
I decided to extract Url drilldown definition into a separate plugin to benefit from regular disabling a plugin feature.
Having it as a separate plugin also makes sense because we will start adding registries specific to URL drilldown implementation

Co-authored-by: Elastic Machine <[email protected]>
Dosant added a commit that referenced this pull request Sep 23, 2020
This pr makes sure there is way to disable URL drilldown feature.
I decided to extract Url drilldown definition into a separate plugin to benefit from regular disabling a plugin feature.
Having it as a separate plugin also makes sense because we will start adding registries specific to URL drilldown implementation

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 23, 2020
* master: (31 commits)
  skip tests for old pacakge (elastic#78194)
  [Ingest Pipelines] Add url generator for ingest pipelines app (elastic#77872)
  [Lens] Rename "telemetry" to "stats" (elastic#78125)
  [CSM] Url search (elastic#77516)
  [Drilldowns] Config to disable URL Drilldown  (elastic#77887)
  [Lens] Combined histogram/range aggregation for numbers (elastic#76121)
  Remove legacy plugins support (elastic#77599)
  'Auto' interval must be correctly calculated for natural numbers (elastic#77995)
  [CSM] fix ingest data retry order messed up (elastic#78163)
  Add response status helpers (elastic#78006)
  Bump react-beautiful-dnd (elastic#78028)
  [Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (elastic#78004)
  Index pattern  - refactor constructor (elastic#77791)
  Add `xpack.security.sameSiteCookies` to docker allow list (elastic#78192)
  Remove [key: string]: any; from IIndexPattern (elastic#77968)
  Remove requirement for manage_index_templates privilege for Index Management (elastic#77377)
  [Ingest Manager] Agent bulk actions UI (elastic#77690)
  [Metrics UI] Add inventory view timeline (elastic#77804)
  Reporting/Docs: Updates for setting to enable CSV Download (elastic#78101)
  Update to latest rum-react (elastic#78193)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants