[Ingest Manager] Fix condition for filtering to installed packages #79205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
bug
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
approved these changes
Oct 1, 2020
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Oct 1, 2020
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Oct 1, 2020
# Conflicts: # x-pack/plugins/ingest_manager/server/services/epm/packages/get.ts
jen-huang
added a commit
that referenced
this pull request
Oct 1, 2020
|
@jen-huang When I was working on a demo, I perceived a slowness in the "search box" in the add integration would that fix that? cc @mostlyjason |
|
@ph Yes this fix should speed that up. |
jen-huang
added a commit
that referenced
this pull request
Oct 2, 2020
|
Hi @jen-huang We have validated this defect on latest 7.9.3 BC1 Kibana Cloud environment with commit 289d920 Observed that:
Screenshot:
Screenshot:
Please let us know if anything is missing from our end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #71289. Fixes a silly typo in the condition where we check for installed packages, before checking if the package is limited. The typo caused us to fetch all packages rather than just installed packages 🤦🏻♀️
I happened to run into this due to getting an error about a missing package after I switched between remote and local registries. Fortunately, this didn't have any consequences on our releases apart from slowing the loading of
Add integrationselection step.