Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Improve logging about re-creating requests #79209

Closed

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Oct 1, 2020

Summary

Goal: This PR is a followup to #76998 to improve the tags in logs generated during report queuing and executing. By passing in a logger to the ReportingCore functions instead of using a class member of ReportingCore, the logger object is able to carry with it the tags that have accumulated through different modules that lead up the the logging call. This adds more context to the logs.

By doing this, this area of logging is brought up to the standard of logging in Reporting.

This PR also converts the log level to debug when the Space ID is default

BEFORE:

[13:54:41.644] [info][plugins][reporting] Request uses Space ID: non_default_space

AFTER:

[13:54:41.644] [info][plugins][queue-job][reporting] Request uses Space ID: non_default_space

Checklist

Delete any items that are not applicable to this PR.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 1, 2020

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

closing this because it will end up churning with the task manager PR

@tsullivan tsullivan closed this Oct 1, 2020
@tsullivan tsullivan deleted the reporting/improve/logging branch October 2, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants