[Monitoring] Thread pool rejections alert

packages/kbn-optimizer/limits.yml

@@ -54,7 +54,7 @@ pageLoadAssetSize:
  mapsLegacy: 116817
  mapsLegacyLicensing: 20214
  ml: 82187
- monitoring: 268612
+ monitoring: 288612
  navigation: 37269
  newsfeed: 42228
  observability: 89709

x-pack/plugins/monitoring/common/constants.ts

@@ -238,6 +238,8 @@ export const ALERT_KIBANA_VERSION_MISMATCH = `${ALERT_PREFIX}alert_kibana_versio
 export const ALERT_LOGSTASH_VERSION_MISMATCH = `${ALERT_PREFIX}alert_logstash_version_mismatch`;
 export const ALERT_MEMORY_USAGE = `${ALERT_PREFIX}alert_jvm_memory_usage`;
 export const ALERT_MISSING_MONITORING_DATA = `${ALERT_PREFIX}alert_missing_monitoring_data`;
+export const ALERT_THREAD_POOL_SEARCH_REJECTIONS = `${ALERT_PREFIX}alert_thread_pool_search_rejections`;
+export const ALERT_THREAD_POOL_WRITE_REJECTIONS = `${ALERT_PREFIX}alert_thread_pool_write_rejections`;
 
 /**
  * A listing of all alert types
@@ -253,6 +255,8 @@ export const ALERTS = [
  ALERT_LOGSTASH_VERSION_MISMATCH,
  ALERT_MEMORY_USAGE,
  ALERT_MISSING_MONITORING_DATA,
+ ALERT_THREAD_POOL_SEARCH_REJECTIONS,
+ ALERT_THREAD_POOL_WRITE_REJECTIONS,
 ];
 
 /**

x-pack/plugins/monitoring/common/enums.ts

@@ -25,6 +25,7 @@ export enum AlertMessageTokenType {
 export enum AlertParamType {
  Duration = 'duration',
  Percentage = 'percentage',
+ Number = 'number',
 }
 
 export enum SetupModeFeature {

x-pack/plugins/monitoring/common/types.ts

@@ -41,7 +41,7 @@ export interface CommonAlertStackProductFilter extends CommonAlertFilter {
 
 export interface CommonAlertParamDetail {
  label: string;
- type: AlertParamType;
+ type?: AlertParamType;
 }
 
 export interface CommonAlertParamDetails {
@@ -51,3 +51,8 @@ export interface CommonAlertParamDetails {
 export interface CommonAlertParams {
  [name: string]: string | number;
 }
+
+export interface ThreadPoolRejectionsAlertParams {
+ threshold: number;
+ duration: string;
+}

x-pack/plugins/monitoring/public/alerts/components/duration/expression.tsx

@@ -10,6 +10,7 @@ import { CommonAlertParamDetails } from '../../../../common/types';
 import { AlertParamDuration } from '../../flyout_expressions/alert_param_duration';
 import { AlertParamType } from '../../../../common/enums';
 import { AlertParamPercentage } from '../../flyout_expressions/alert_param_percentage';
+import { AlertParamNumber } from '../../flyout_expressions/alert_param_number';
 
 export interface Props {
  alertParams: { [property: string]: any };
@@ -49,6 +50,17 @@ export const Expression: React.FC<Props> = (props) => {
  setAlertParams={setAlertParams}
  />
  );
+ case AlertParamType.Number:
+ return (
+ <AlertParamNumber
+ key={alertParamName}
+ name={alertParamName}
+ label={details.label}
+ value={value}
+ errors={errors[alertParamName]}
+ setAlertParams={setAlertParams}
+ />
+ );
  }
  });
 

x-pack/plugins/monitoring/public/alerts/flyout_expressions/alert_param_duration.tsx

@@ -69,7 +69,7 @@ export const AlertParamDuration: React.FC<Props> = (props: Props) => {
  }, [unit, value]);
 
  return (
- <EuiFormRow label={label} error={errors} isInvalid={errors.length > 0}>
+ <EuiFormRow label={label} error={errors} isInvalid={errors?.length > 0}>
  <EuiFlexGroup>
  <EuiFlexItem grow={2}>
  <EuiFieldNumber

x-pack/plugins/monitoring/public/alerts/flyout_expressions/alert_param_number.tsx

@@ -0,0 +1,36 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import React, { useState } from 'react';
+import { EuiFormRow, EuiFieldNumber } from '@elastic/eui';
+
+interface Props {
+ name: string;
+ value: number;
+ label: string;
+ errors: string[];
+ setAlertParams: (property: string, value: number) => void;
+}
+export const AlertParamNumber: React.FC<Props> = (props: Props) => {
+ const { name, label, setAlertParams, errors } = props;
+ const [value, setValue] = useState(props.value);
+ return (
+ <EuiFormRow label={label} error={errors} isInvalid={errors?.length > 0}>
+ <EuiFieldNumber
+ compressed
+ value={value}
+ onChange={(e) => {
+ let newValue = Number(e.target.value);
+ if (isNaN(newValue)) {
+ newValue = 0;
+ }
+ setValue(newValue);
+ setAlertParams(name, newValue);
+ }}
+ />
+ </EuiFormRow>
+ );
+};

x-pack/plugins/monitoring/public/alerts/thread_pool_rejections_alert/index.tsx

@@ -0,0 +1,60 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import React from 'react';
+import { i18n } from '@kbn/i18n';
+import { EuiSpacer } from '@elastic/eui';
+import { Expression, Props } from '../components/duration/expression';
+// eslint-disable-next-line @kbn/eslint/no-restricted-paths
+import { AlertTypeModel } from '../../../../triggers_actions_ui/public/types';
+import { CommonAlertParamDetails } from '../../../common/types';
+
+interface ThreadPoolTypes {
+ [key: string]: unknown;
+}
+
+interface ThreadPoolRejectionAlertClass {
+ TYPE: string;
+ LABEL: string;
+ PARAM_DETAILS: CommonAlertParamDetails;
+}
+
+export function createThreadPoolRejectionsAlertType(
+ threadPoolAlertClass: ThreadPoolRejectionAlertClass
+): AlertTypeModel {
+ return {
+ id: threadPoolAlertClass.TYPE,
+ name: threadPoolAlertClass.LABEL,
+ iconClass: 'bell',
+ alertParamsExpression: (props: Props) => (
+ <>
+ <EuiSpacer />
+ <Expression {...props} paramDetails={threadPoolAlertClass.PARAM_DETAILS} />
+ </>
+ ),
+ validate: (inputValues: ThreadPoolTypes) => {
+ const errors: { [key: string]: string[] } = {};
+ const value = inputValues.threshold as number;
+ if (value < 0) {
+ const errStr = i18n.translate('xpack.monitoring.alerts.validation.lessThanZero', {
+ defaultMessage: 'This value can not be less than zero',
+ });
+ errors.threshold = [errStr];
+ }
+
+ if (!inputValues.duration) {
+ const errStr = i18n.translate('xpack.monitoring.alerts.validation.duration', {
+ defaultMessage: 'A valid duration is required.',
+ });
+ errors.duration = [errStr];
+ }
+
+ return { errors };
+ },
+ defaultActionMessage: '{{context.internalFullMessage}}',
+ requiresAppContext: true,
+ };
+}

x-pack/plugins/monitoring/public/angular/providers/private.js

@@ -81,9 +81,9 @@
  *
  * @param {[type]} prov [description]
  */
-import _ from 'lodash';
+import { partial, uniqueId, isObject } from 'lodash';
 
-const nextId = _.partial(_.uniqueId, 'privateProvider#');
+const nextId = partial(uniqueId, 'privateProvider#');
 
 function name(fn) {
  return fn.name || fn.toString().split('\n').shift();
@@ -141,7 +141,7 @@ export function PrivateProvider() {
 
  const context = {};
  let instance = $injector.invoke(prov, context, locals);
- if (!_.isObject(instance)) instance = context;
+ if (!isObject(instance)) instance = context;
 
  privPath.pop();
  return instance;
@@ -155,7 +155,7 @@ export function PrivateProvider() {
 
  if ($delegateId != null && $delegateProv != null) {
  instance = instantiate(prov, {
- $decorate: _.partial(get, $delegateId, $delegateProv),
+ $decorate: partial(get, $delegateId, $delegateProv),
  });
  } else {
  instance = instantiate(prov);

x-pack/plugins/monitoring/public/components/chart/chart_target.js

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import _ from 'lodash';
+import { get, isEqual, filter } from 'lodash';
 import $ from 'jquery';
 import React from 'react';
 import { eventBus } from './event_bus';
@@ -50,12 +50,12 @@ export class ChartTarget extends React.Component {
  }
 
  UNSAFE_componentWillReceiveProps(newProps) {
- if (this.plot && !_.isEqual(newProps, this.props)) {
+ if (this.plot && !isEqual(newProps, this.props)) {
  const { series, timeRange } = newProps;
 
  const xaxisOptions = this.plot.getAxes().xaxis.options;
- xaxisOptions.min = _.get(timeRange, 'min');
- xaxisOptions.max = _.get(timeRange, 'max');
+ xaxisOptions.min = get(timeRange, 'min');
+ xaxisOptions.max = get(timeRange, 'max');
 
  this.plot.setData(this.filterData(series, newProps.seriesToShow));
  this.plot.setupGrid();
@@ -73,7 +73,7 @@ export class ChartTarget extends React.Component {
  }
 
  filterData(data, seriesToShow) {
- return _(data).filter(this.filterByShow(seriesToShow)).value();
+ return filter(data, this.filterByShow(seriesToShow)).value();
  }
 
  async getOptions() {
@@ -128,7 +128,7 @@ export class ChartTarget extends React.Component {
  this.handleThorPlotHover = (_event, pos, item, originalPlot) => {
  if (this.plot !== originalPlot) {
  // the crosshair is set for the original chart already
- this.plot.setCrosshair({ x: _.get(pos, 'x') });
+ this.plot.setCrosshair({ x: get(pos, 'x') });
  }
  this.props.updateLegend(pos, item);
  };

x-pack/plugins/monitoring/public/components/chart/timeseries_visualization.js

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import _ from 'lodash';
+import { debounce, keys, has, includes, isFunction, difference, assign } from 'lodash';
 import React from 'react';
 import { getLastValue } from './get_last_value';
 import { TimeseriesContainer } from './timeseries_container';
@@ -17,7 +17,7 @@ export class TimeseriesVisualization extends React.Component {
  constructor(props) {
  super(props);
 
- this.debouncedUpdateLegend = _.debounce(this.updateLegend, DEBOUNCE_SLOW_MS);
+ this.debouncedUpdateLegend = debounce(this.updateLegend, DEBOUNCE_SLOW_MS);
  this.debouncedUpdateLegend = this.debouncedUpdateLegend.bind(this);
 
  this.toggleFilter = this.toggleFilter.bind(this);
@@ -26,18 +26,18 @@ export class TimeseriesVisualization extends React.Component {
 
  this.state = {
  values: {},
- seriesToShow: _.keys(values),
+ seriesToShow: keys(values),
  ignoreVisibilityUpdates: false,
  };
  }
 
  filterLegend(id) {
- if (!_.has(this.state.values, id)) {
+ if (!has(this.state.values, id)) {
  return [];
  }
 
- const notAllShown = _.keys(this.state.values).length !== this.state.seriesToShow.length;
- const isCurrentlyShown = _.includes(this.state.seriesToShow, id);
+ const notAllShown = keys(this.state.values).length !== this.state.seriesToShow.length;
+ const isCurrentlyShown = includes(this.state.seriesToShow, id);
  const seriesToShow = [];
 
  if (notAllShown && isCurrentlyShown) {
@@ -59,7 +59,7 @@ export class TimeseriesVisualization extends React.Component {
  toggleFilter(_event, id) {
  const seriesToShow = this.filterLegend(id);
 
- if (_.isFunction(this.props.onFilter)) {
+ if (isFunction(this.props.onFilter)) {
  this.props.onFilter(seriesToShow);
  }
  }
@@ -94,21 +94,21 @@ export class TimeseriesVisualization extends React.Component {
  getValuesByX(this.props.series, pos.x, setValueCallback);
  }
  } else {
- _.assign(values, this.getLastValues());
+ assign(values, this.getLastValues());
  }
 
  this.setState({ values });
  }
 
  UNSAFE_componentWillReceiveProps(props) {
  const values = this.getLastValues(props);
- const currentKeys = _.keys(this.state.values);
- const keys = _.keys(values);
- const diff = _.difference(keys, currentKeys);
+ const currentKeys = keys(this.state.values);
+ const valueKeys = keys(values);
+ const diff = difference(valueKeys, currentKeys);
  const nextState = { values: values };
 
  if (diff.length && !this.state.ignoreVisibilityUpdates) {
- nextState.seriesToShow = keys;
+ nextState.seriesToShow = valueKeys;
  }
 
  this.setState(nextState);

x-pack/plugins/monitoring/public/components/cluster/overview/elasticsearch_panel.js

@@ -41,6 +41,8 @@ import {
  ALERT_CLUSTER_HEALTH,
  ALERT_CPU_USAGE,
  ALERT_DISK_USAGE,
+ ALERT_THREAD_POOL_SEARCH_REJECTIONS,
+ ALERT_THREAD_POOL_WRITE_REJECTIONS,
  ALERT_MEMORY_USAGE,
  ALERT_NODES_CHANGED,
  ALERT_ELASTICSEARCH_VERSION_MISMATCH,
@@ -162,6 +164,8 @@ const OVERVIEW_PANEL_ALERTS = [ALERT_CLUSTER_HEALTH, ALERT_LICENSE_EXPIRATION];
 const NODES_PANEL_ALERTS = [
  ALERT_CPU_USAGE,
  ALERT_DISK_USAGE,
+ ALERT_THREAD_POOL_SEARCH_REJECTIONS,
+ ALERT_THREAD_POOL_WRITE_REJECTIONS,
  ALERT_MEMORY_USAGE,
  ALERT_NODES_CHANGED,
  ALERT_ELASTICSEARCH_VERSION_MISMATCH,

x-pack/plugins/monitoring/public/components/elasticsearch/nodes/nodes.js

@@ -27,7 +27,7 @@ import {
  EuiHealth,
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
-import _ from 'lodash';
+import { get } from 'lodash';
 import { ELASTICSEARCH_SYSTEM_ID } from '../../../../common/constants';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { ListingCallOut } from '../../setup_mode/listing_callout';
@@ -58,7 +58,7 @@ const getNodeTooltip = (node) => {
  return null;
 };
 
-const getSortHandler = (type) => (item) => _.get(item, [type, 'summary', 'lastVal']);
+const getSortHandler = (type) => (item) => get(item, [type, 'summary', 'lastVal']);
 const getColumns = (showCgroupMetricsElasticsearch, setupMode, clusterUuid, alerts) => {
  const cols = [];
 
@@ -87,7 +87,7 @@ const getColumns = (showCgroupMetricsElasticsearch, setupMode, clusterUuid, aler
 
  let setupModeStatus = null;
  if (isSetupModeFeatureEnabled(SetupModeFeature.MetricbeatMigration)) {
- const list = _.get(setupMode, 'data.byUuid', {});
+ const list = get(setupMode, 'data.byUuid', {});
  const status = list[node.resolver] || {};
  const instance = {
  uuid: node.resolver,
@@ -396,7 +396,7 @@ export function ElasticsearchNodes({ clusterStatus, showCgroupMetricsElasticsear
  setupMode.data.totalUniqueInstanceCount
  ) {
  const finishMigrationAction =
- _.get(setupMode.meta, 'liveClusterUuid') === clusterUuid
+ get(setupMode.meta, 'liveClusterUuid') === clusterUuid
  ? setupMode.shortcutToFinishMigration
  : setupMode.openFlyout;