-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move api/ingest tests to mocha #8106
Commits on Aug 30, 2016
-
upgrade eslint, all related deps, and config files
spalger committedAug 30, 2016 Configuration menu - View commit details
-
Copy full SHA for 0d827ff - Browse repository at this point
Copy the full SHA 0d827ffView commit details -
arrow-IIFEs must be invoked outside of the parens
spalger committedAug 30, 2016 Configuration menu - View commit details
-
Copy full SHA for 3afec3d - Browse repository at this point
Copy the full SHA 3afec3dView commit details -
move import statements before their use
spalger committedAug 30, 2016 Configuration menu - View commit details
-
Copy full SHA for f518267 - Browse repository at this point
Copy the full SHA f518267View commit details -
reindent to satisfy new indentation check algorithm
spalger committedAug 30, 2016 Configuration menu - View commit details
-
Copy full SHA for f00064f - Browse repository at this point
Copy the full SHA f00064fView commit details -
consolidate eslint ignore paths in .eslintignore
spalger committedAug 30, 2016 Configuration menu - View commit details
-
Copy full SHA for 9f56f6c - Browse repository at this point
Copy the full SHA 9f56f6cView commit details -
re-enable no-var rule and autofix violations
this became auto-fixable in eslint v3, it was previously applied to only part of the code base
spalger committedAug 30, 2016 Configuration menu - View commit details
-
Copy full SHA for 7dd4b33 - Browse repository at this point
Copy the full SHA 7dd4b33View commit details -
re-enable and autofix prefer-const rule
this became auto-fixable in eslint v3, it was previously fixed manually in part of the code base
spalger committedAug 30, 2016 Configuration menu - View commit details
-
Copy full SHA for 1e50d9e - Browse repository at this point
Copy the full SHA 1e50d9eView commit details -
re-enable and autofix no-extra-semi rule
this rule was added to the shared eslint config[1] and was automatically fixed [1]: https:/elastic/eslint-config-kibana
spalger committedAug 30, 2016 Configuration menu - View commit details
-
Copy full SHA for ba48490 - Browse repository at this point
Copy the full SHA ba48490View commit details -
re-enable and autofix quotes rule
this became auto-fixable in eslint v3
spalger committedAug 30, 2016 Configuration menu - View commit details
-
Copy full SHA for 4d7f99c - Browse repository at this point
Copy the full SHA 4d7f99cView commit details
Commits on Aug 31, 2016
-
re-enable and fix no-unused-vars rule
this was added to the shared eslint config[1] a while ago and is not autofixable. Instead, a collection of custom jscodeshift transforms[2] were used to fix certain violation formats, and the rest was fixed manually. [1]: https:/elastic/eslint-config-kibana [2]: https:/kreeware/kibana-jscodeshift/tree/master/transforms
spalger committedAug 31, 2016 Configuration menu - View commit details
-
Copy full SHA for 1bdf735 - Browse repository at this point
Copy the full SHA 1bdf735View commit details -
enable and autofix object-curly-spacing rule
The import statements produced by jscodeshift do not put spaces between the properties and the curly-braces used in destructuring import statements. This is different from the style they are usually written in, so I enabled this rule to fix them and ensure we keep with the current style.
spalger committedAug 31, 2016 Configuration menu - View commit details
-
Copy full SHA for ebfcca0 - Browse repository at this point
Copy the full SHA ebfcca0View commit details -
restore accidentally removed stubs, timers, initializations
Several of the timer stubs created a reference to a clock variable, but never used that variable, so they were causing no-unused-vars errors. In the process of fixing those errors, some of those must have been removed, which caused some test failures.
spalger committedAug 31, 2016 Configuration menu - View commit details
-
Copy full SHA for 4b43cdc - Browse repository at this point
Copy the full SHA 4b43cdcView commit details -
move api/ingest tests into server test runner
When the tests for the api were written, they ended up using intern. This is not desirable for a number of reasons, but in an effort to remove all remaining `require()` calls I decided to give this migration a shot. Moving the tests to mocha was actually trivial.
spalger committedAug 31, 2016 Configuration menu - View commit details
-
Copy full SHA for 76c9a3d - Browse repository at this point
Copy the full SHA 76c9a3dView commit details