Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move api/ingest tests to mocha #8106

Closed
wants to merge 13 commits into from
Closed

Commits on Aug 30, 2016

  1. Configuration menu
    Copy the full SHA
    0d827ff View commit details
    Browse the repository at this point in the history
  2. arrow-IIFEs must be invoked outside of the parens

    spalger committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    3afec3d View commit details
    Browse the repository at this point in the history
  3. move import statements before their use

    spalger committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    f518267 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f00064f View commit details
    Browse the repository at this point in the history
  5. consolidate eslint ignore paths in .eslintignore

    spalger committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    9f56f6c View commit details
    Browse the repository at this point in the history
  6. re-enable no-var rule and autofix violations

    this became auto-fixable in eslint v3, it was previously applied to only part of the code base
    spalger committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    7dd4b33 View commit details
    Browse the repository at this point in the history
  7. re-enable and autofix prefer-const rule

    this became auto-fixable in eslint v3, it was previously fixed manually in part of the code base
    spalger committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    1e50d9e View commit details
    Browse the repository at this point in the history
  8. re-enable and autofix no-extra-semi rule

    this rule was added to the shared eslint config[1] and was automatically fixed
    
    [1]: https:/elastic/eslint-config-kibana
    spalger committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    ba48490 View commit details
    Browse the repository at this point in the history
  9. re-enable and autofix quotes rule

    this became auto-fixable in eslint v3
    spalger committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    4d7f99c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2016

  1. re-enable and fix no-unused-vars rule

    this was added to the shared eslint config[1] a while ago and is not autofixable. Instead, a collection of custom jscodeshift transforms[2] were used to fix certain violation formats, and the rest was fixed manually.
    
    [1]: https:/elastic/eslint-config-kibana
    [2]: https:/kreeware/kibana-jscodeshift/tree/master/transforms
    spalger committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    1bdf735 View commit details
    Browse the repository at this point in the history
  2. enable and autofix object-curly-spacing rule

    The import statements produced by jscodeshift do not put spaces between the properties and the curly-braces used in destructuring import statements. This is different from the style they are usually written in, so I enabled this rule to fix them and ensure we keep with the current style.
    spalger committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    ebfcca0 View commit details
    Browse the repository at this point in the history
  3. restore accidentally removed stubs, timers, initializations

    Several of the timer stubs created a reference to a clock variable, but never used that variable, so they were causing no-unused-vars errors. In the process of fixing those errors, some of those must have been removed, which caused some test failures.
    spalger committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    4b43cdc View commit details
    Browse the repository at this point in the history
  4. move api/ingest tests into server test runner

    When the tests for the api were written, they ended up using intern. This is not desirable for a number of reasons, but in an effort to remove all remaining `require()` calls I decided to give this migration a shot. Moving the tests to mocha was actually trivial.
    spalger committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    76c9a3d View commit details
    Browse the repository at this point in the history