Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unsigned_long fields #81115

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Oct 20, 2020

Summary

Closes #81075

Add support for unsigned_long (introduced by elastic/elasticsearch#60050) that are introduced in 7.10.

This simply makes this also number fields, so they work as every other numerical ES type too.

A dev console script to test this:


PUT long-test
{
  "mappings": {
    "properties": {
      "largenumber": {
        "type": "unsigned_long"
      },
      "number": {
        "type": "integer"
      }
    }
  }
}

POST long-test/_doc
{
  "largenumber": 987654678909076,
  "number": 98765
}

Now create an index pattern on that index and make sure that this field works across Kibana.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@timroes timroes requested a review from a team as a code owner October 20, 2020 08:50
@timroes timroes added v7.10.0 v7.11.0 v8.0.0 release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
data 1.1MB 1.1MB +73.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@timroes timroes added the Feature:New Field Type Add support for an Elasticsearch field type in Kibana label Oct 20, 2020
@timroes timroes merged commit 3a206ab into elastic:master Oct 20, 2020
@timroes timroes deleted the feat/unsigned_long branch October 20, 2020 11:58
timroes pushed a commit to timroes/kibana that referenced this pull request Oct 20, 2020
* Support unsigned_long fields

* Change API docs
timroes pushed a commit to timroes/kibana that referenced this pull request Oct 20, 2020
* Support unsigned_long fields

* Change API docs
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 20, 2020
* master: (64 commits)
  Rename Security Solution Bug Template (elastic#81187)
  Update links (elastic#81125)
  Specify format for date range query (elastic#81025)
  [Alerting] Improve toast when alert is created (elastic#80327)
  [UX] Add empty states (elastic#80904)
  Add TS config for kibana_legacy (elastic#80992)
  [Telemetry] Add method to enable endpoint security data usage example (elastic#80940)
  [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794)
  Fix reactRouterNavigate when used with a string (elastic#80520)
  [Security Solution] [Detections] Read privileges for dependencies (elastic#80852)
  [ML] Fixing exclude frequent in advanced wizard (elastic#81121)
  Fix security solution template label (elastic#80976)
  [DOCS] Update index management docs (elastic#80893)
  [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814)
  skip flaky suite (elastic#81072)
  [Task Manager] Cleans up legacy plugin structure (elastic#80381)
  Support unsigned_long fields (elastic#81115)
  [Form lib] Export internal state instead of raw state (elastic#80842)
  [Lens] Add toast notification when visualization is saved (elastic#80788)
  Index pattern edit field formatter API (elastic#78352)
  ...
timroes pushed a commit that referenced this pull request Oct 20, 2020
* Support unsigned_long fields

* Change API docs
timroes pushed a commit that referenced this pull request Oct 20, 2020
* Support unsigned_long fields

* Change API docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Field Type Add support for an Elasticsearch field type in Kibana release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map new Elasticsearch unsigned long to a number in Kibana
5 participants