Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Migrate Task Manager plugin to TS project references #81556

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Oct 23, 2020

Resolve one required from Plugins to migrate:

  • task_manager

Added tsconfig.json file to task_manager plugin folder with the proper configuration optimization options, which described in the documentation and Kibana example. This changes should improve build times and enforce logical separation between components.

After successful build the folder was added under the task_manager:
img

@YulNaumenko YulNaumenko added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 labels Oct 23, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner October 23, 2020 04:13
@YulNaumenko YulNaumenko self-assigned this Oct 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

…ate-to-ts-config

# Conflicts:
#	x-pack/test/tsconfig.json
#	x-pack/tsconfig.json
#	x-pack/tsconfig.refs.json
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 27, 2020

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: metrics for 2e7f96b were not reported

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko
Copy link
Contributor Author

Closed based on the PR

@YulNaumenko YulNaumenko closed this Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Alerting plugins (including Task Manager and Event Log) to TS project references
4 participants