Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.10] [Security Solutions][Detection Engine] Fixes critical bug with error reporting that was doing a throw (#81549) #81729

Merged
merged 1 commit into from
Oct 27, 2020
Merged

[7.10] [Security Solutions][Detection Engine] Fixes critical bug with error reporting that was doing a throw (#81549) #81729

merged 1 commit into from
Oct 27, 2020

Conversation

FrankHassanabad
Copy link
Contributor

Backports the following commits to 7.10:

@FrankHassanabad
[Security Solutions][Detection Engine] Fixes critical bug with error …
f35b83f 
…reporting that was doing a throw (elastic#81549)

## Summary

Fixes an error where it was expecting some data structures on an ES error but there wasn't in some cases.

Before:
<img width="2246" alt="Screen Shot 2020-10-22 at 1 04 35 PM" src="https://user-images.githubusercontent.com/1151048/96940994-7d98a780-148e-11eb-93bd-77e4adf42896.png">

After:
<img width="2229" alt="Screen Shot 2020-10-22 at 5 45 31 PM" src="https://user-images.githubusercontent.com/1151048/96941005-84bfb580-148e-11eb-989f-1dae6892e641.png">

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@FrankHassanabad FrankHassanabad merged commit 63f4cec into elastic:7.10 Oct 27, 2020
@FrankHassanabad FrankHassanabad deleted the backport/7.10/pr-81549 branch October 27, 2020 06:58
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankHassanabad @kibanamachine @MindyRS