[Security Solutions][Detections] - Fix bug, last response not showing for disabled rules

[yctercero]

Summary

Bug fix addressed in this PR:

• fixes [SIEM] Last run/response are not displayed for a disabled rule #63203
• in the backend, we were only fetching status data for enabled rules, changed to fetch status data regardles of whether rule is enabled or disabled

Example of bug

Example of fix

Checklist

• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

[elasticmachine]

Pinging @elastic/siem (Team:SIEM)

[yctercero]

This wasn't typed because some areas were passing through ruleStatuses.saved_objects[0] and some were passing ruleStatuses. Added the correct type and adjusted use cases so they all just pass in ruleStatuses since we were already making checks within for the existence of .saved_objects[0] .

[FrankHassanabad]

Yeah, I think the pattern from Kibana core/other areas go:

• They don't have types or use any or unknown, so let's use unknown for now/cast.
• Later someone adds templates, types, such as SavedObjectsFindResponse
• Someone else looks at our code and says, "lol, why you using unknown here, let me change that"

So thank you very much. This looks better.

[yctercero]

@elasticmachine merge upstream

[FrankHassanabad]

nit: Through out this test I would recommend just weakening your types to avoid the ts-expect-error (but I do appreciate you using ts-expect-error 👍 like so:

    test('it should return error object if "alert" is not expected alert type', () => {
      const { alertTypeId, ...ruleAlert } = getResult();
      const validatedOrError = transformValidateBulkError('rule-1', ruleAlert);
      const expected: BulkError = {
        error: {
          message: 'Internal error transforming',
          status_code: 500,
        },
        rule_id: 'rule-1',
      };
      expect(validatedOrError).toEqual(expected);
    });

Either way works, I mostly use this way to avoid the newer TS errors on deleting things that used to not be there.

[FrankHassanabad]

LGTM! Love all of it, makes everything look so much more useful and better.

[yctercero]

@elasticmachine merge upstream

[yctercero]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: ba8c8ac

Metrics [docs]

async chunks size

id	before	after	diff
securitySolution	8.1MB	8.1MB	+95.0B

History

• 💔 Build #84085 failed bba1661
• 💔 Build #84051 failed 65d4cb3
• 💔 Build #83954 failed 116f443

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream